Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading comments #79

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Add support for reading comments #79

merged 4 commits into from
Sep 23, 2022

Conversation

bimbashrestha
Copy link
Member

Adds a Comment class and a get_comments() method. Need this for the notion-qms.

Copy link
Contributor

@johndgiese johndgiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I had one small request, but feel free to merge once addressed

n2y/comment.py Show resolved Hide resolved
n2y/notion.py Outdated Show resolved Hide resolved
tests/test_end_to_end.py Show resolved Hide resolved
@@ -336,6 +331,17 @@ def _post_url(self, url, data=None):
response = requests.post(url, headers=self.headers, json=data)
return self._parse_response(response)

def _paginated_request(self, request_method, url, initial_params):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this new helper btw @johndgiese

@bimbashrestha bimbashrestha merged commit 5f109ea into main Sep 23, 2022
@johndgiese johndgiese deleted the comments branch December 8, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants