-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework table richtext bug fix #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @sHermanGriffiths!
Add a quick test for your change and this looks good to go. Maybe we can just edit the test case you deleted?
@@ -21,8 +21,3 @@ def test_plain_text_to_pandoc_spaces_after(): | |||
def test_plain_text_to_pandoc_spaces_after_newline(): | |||
pandoc_ast = RichText.plain_text_to_pandoc("hello\n world") | |||
assert pandoc_ast == [Str("hello"), LineBreak(), Space(), Space(), Str("world")] | |||
|
|||
|
|||
def test_plain_text_to_pandoc_table(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you're deleting this test case because it breaks after your changes? Let's fix the test case so that it works with your changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created it as a test case for the previous changes
Thanks for pulling this out into it's own PR! Reviewing it like this is so much easier :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sHermanGriffiths please add a test that catches the bug you fixed in this PR before merging. Good job with the fix.
230f9dd
to
30a4df8
Compare
Author's Checklist
Before assigning reviewers, step through the following checklist. Check each item once it's completed. If an item is skipped, write an explanation below the item.
N\A
N\A
N\A
N\A
N\A