rework table richtext bug fix #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bimbashrestha
requested changes
Dec 21, 2022
There was a problem hiding this comment.
Nice work @sHermanGriffiths!
Add a quick test for your change and this looks good to go. Maybe we can just edit the test case you deleted?
| @@ -21,8 +21,3 @@ def test_plain_text_to_pandoc_spaces_after(): | |||
| def test_plain_text_to_pandoc_spaces_after_newline(): | |||
| pandoc_ast = RichText.plain_text_to_pandoc("hello\n world") | |||
| assert pandoc_ast == [Str("hello"), LineBreak(), Space(), Space(), Str("world")] | |||
|
|
|||
|
|
|||
| def test_plain_text_to_pandoc_table(): | |||
There was a problem hiding this comment.
I assume you're deleting this test case because it breaks after your changes? Let's fix the test case so that it works with your changes.
There was a problem hiding this comment.
I created it as a test case for the previous changes
|
Thanks for pulling this out into it's own PR! Reviewing it like this is so much easier :) |
bimbashrestha
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
@sHermanGriffiths please add a test that catches the bug you fixed in this PR before merging. Good job with the fix.
sHermanGriffiths
force-pushed
the
tablefix
branch
from
230f9dd
to
30a4df8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author's Checklist
Before assigning reviewers, step through the following checklist. Check each item once it's completed. If an item is skipped, write an explanation below the item.
N\A
N\A
N\A
N\A
N\A