Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine views for conversations and individual posts #19

Closed
FND opened this issue Nov 27, 2012 · 11 comments
Closed

combine views for conversations and individual posts #19

FND opened this issue Nov 27, 2012 · 11 comments

Comments

@FND
Copy link
Member

FND commented Nov 27, 2012

I can't think of a reason why we'd wanna keep them separate

@stilkov
Copy link
Contributor

stilkov commented Aug 7, 2013

Have we really not discussed this before? Unsure.

I don't know how to handle updates to conversations. Should they appear at the top? Inline within the conversation? Both?

@aheusingfeld
Copy link
Contributor

I don't know how to handle updates to conversations. Should they appear at the top? Inline within the conversation?

I assume we're talking about the conversation view and not about the timeline. Personally I don't like the conversation view which is displayed inside the timeline of Twitter's webUI. But what I do love is the way they highlight the selected tweet inside of a conversation view. Tweets created before this are shown above and tweets created later are shown below this tweet. Sort in ascending order by creation timestamp.

I'd hereby like to suggest to do the same for our statuses app. :)

@FND
Copy link
Member Author

FND commented Aug 8, 2013

I'm not sure we're still talking about the original issue here, which was to combine the views (resources even) for /conversation/<id> and /updates/<id>.

I don't know how to handle updates to conversations.

The way it currently works seems fine, or am I missing anything?

@aheusingfeld
Copy link
Contributor

the original issue here, which was to combine the views (resources even) for /conversation/ and /updates/.

I understood Stefan's question in a context of visualization. Thus my comment above was on how we could display updates to the conversation view. But as I resume and look at the list of issues, this is actually the topic of #9 and therefore should better be moved overthere. Agreed?

@aheusingfeld
Copy link
Contributor

I'd like to come back to my suggestion above

Tweets created before this are shown above and tweets created later are shown below this tweet. Sort in ascending order by creation timestamp.

With this applied we only have the /updates/{id} (no /conversations/* anymore) and a specific update's view could look something like this
screen shot 2014-10-23 at 22 36 17

Changes:

  • added a current css class to the current li.post
  • added the following css - as a very rough sample:
    <style type="text/css">
    .post { font-size: 0.8em; margin-left: 1em;}
    .current { 
        background-color: #FFD; 
        font-size: 1.2em;
        margin-left: 0;
    }
    </style>

@stilkov
Copy link
Contributor

stilkov commented Oct 26, 2014

I’m fine with this, please use a PR if you want to.

@aheusingfeld
Copy link
Contributor

@stilkov @FND @mvitz I ran into a situation where I'd like to have your opinions:
Currently we retrieve the reply-form for a certain post by querying /statuses/update/123 via Javascript and parsing the returned HTML. I now changed the layout of /statuses/update/123 to contain the whole conversation. This implies that at the moment the whole conversation is also loaded just to retrieve the reply-form in the main timeline page which seems a bit too awkward to me.

I was thinking to move the reply-form to a separate resource e.g. /statuses/update/123/replyform. On the other hand one could argue that a form is not a resource by itself. How do you think about it?

@stilkov
Copy link
Contributor

stilkov commented Nov 23, 2014

A form to reply seems like a perfectly fine resource to me.

@mvitz
Copy link
Contributor

mvitz commented Nov 23, 2014

I'm not a web expert but to me returning a form as resource seems fine, too. Maybe we should name the resource just reply instead of replyform?!?

@aheusingfeld
Copy link
Contributor

Maybe we should name the resource just reply instead of replyform?!?

Why? It's a form, it's not the reply.

@mvitz
Copy link
Contributor

mvitz commented Nov 23, 2014

You're right. I shouldn't work while watching football ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants