Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show links to images as inline #47

Closed
phaus opened this issue Mar 13, 2013 · 4 comments
Closed

show links to images as inline #47

phaus opened this issue Mar 13, 2013 · 4 comments

Comments

@phaus
Copy link
Contributor

phaus commented Mar 13, 2013

If a Links ends with an extension (or pro version: has ContentType of an Image), it would be great to show that Images as Inline in a Post.

@stilkov
Copy link
Contributor

stilkov commented Jul 18, 2013

Sorry for the late reaction. I'm not sure about this one. How would we do this? Issue HEAD requests to every linked resource and look for image content types? We'd have to cache the result to avoid doing this over and over again. It's a neat idea, but I'm slightly worried about the added complexity (with small benefit).

@stilkov
Copy link
Contributor

stilkov commented Sep 8, 2013

Thinking about this some more, I was wrong and there is no need for caching: We can do the HEAD thing once and just put the img tag into the content. The user’s browser will then retrieve it, obviously no need to do that on the server side. Even simpler, we could allow using img tags in content.

@aheusingfeld
Copy link
Contributor

I unfortunately introduced a duplicate to this with #70. Sorry.

@aheusingfeld
Copy link
Contributor

Done with aheusingfeld@dfc30de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants