Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Info Window #38

Closed
yankeeinlondon opened this issue May 15, 2021 · 12 comments · Fixed by #60
Closed

Add Info Window #38

yankeeinlondon opened this issue May 15, 2021 · 12 comments · Fixed by #60
Labels
feature request New feature

Comments

@yankeeinlondon
Copy link
Contributor

Adding the Info Windows feature to this repo is a feature-request for this library. We are happy to accept PR's for this work as there is not immediate demand internally for this feature but we do understand why it might be useful and it will eventually be incorporated.

@yankeeinlondon yankeeinlondon added the feature request New feature label May 15, 2021
This was referenced May 15, 2021
@Baroshem
Copy link

Baroshem commented Mar 2, 2022

Any news on it? I would really like to have the info windows feature as I really enjoyed using the package so far :)

@web-programmer-here
Copy link

+1 for this feature too, it is going to be very useful

@yankeeinlondon
Copy link
Contributor Author

We're not currently using this functionality so it's not getting a ton of attention but would you consider adding in a pull request? Probably the fastest way to getting this in.

@HusamElbashir
Copy link
Collaborator

Added in v0.8.4. Can be used like this:

<InfoWindow :options="{ position, content: 'Your content here' }" />

Or like this:

<InfoWindow :options="{ position }">
Your content here
</InfoWindow>

Documentation to be added soon

@Baroshem
Copy link

Tested it and it works great. I have one question @husamibrahim. Could you tell me how can I nest a info window inside of a marker so that when I click on a marker it will open an info window?

@eskiesirius
Copy link

may i see the screenshot of this? i cant make this work

@HusamElbashir
Copy link
Collaborator

Could you tell me how can I nest a info window inside of a marker so that when I click on a marker it will open an info window?

This isn't possible in the current iteration @Baroshem but we can definitely add it. You can open a new issue if you like.

@HusamElbashir
Copy link
Collaborator

may i see the screenshot of this? i cant make this work

Please share a reproduction @eskiesirius. You can use https://vite.new/vue.
In any case documentation will be added soon.

@HusamElbashir
Copy link
Collaborator

@Baroshem Added nesting in v0.9.0. Basic syntax is:

<Marker :options="{ position }">
  <InfoWindow>Your content here</InfoWindow>
</Marker>

@Baroshem
Copy link

@husamibrahim This is just great!

Yesterday I managed to create a workaround for the current code to utilize the marker and infowindow like following:

  <div>
    <google-marker :options="options" @click="open = !open"/>
    <info-window
      v-if="popup && open"
      :options="{ ...options, content: popup }"
      @closeclick="open = !open"
    />
  </div>

And today you just added a nested functionality that works even better.

I can now utilize the full functionality. Thank you very much!

I am really happy that I have selected your library instead of others :)

@eskiesirius
Copy link

may i see the screenshot of this? i cant make this work

Please share a reproduction @eskiesirius. You can use https://vite.new/vue. In any case documentation will be added soon.

It is working now.. it is great!

@web-programmer-here
Copy link

@husamibrahim this is great, thank you 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants