Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek better API to override components #219

Closed
inokawa opened this issue Oct 24, 2023 · 2 comments · Fixed by #303
Closed

Seek better API to override components #219

inokawa opened this issue Oct 24, 2023 · 2 comments · Fixed by #303
Assignees

Comments

@inokawa
Copy link
Owner

inokawa commented Oct 24, 2023

A few things we have to take into consideration:

  • We may use virtua with some component libraries like Material UI, Radix UI, etc.
  • Some elements require specific parent/children elements. For example ul requires li as children, and table requires hierarchy of table -> tbody -> tr -> td.
  • In some case, we want to add padding to root component and it requires some special calculation. Paddings not taken into account in reverse mode  #216
  • Adding header/footer/spinner to top/bottom of list is commonly used.
@inokawa inokawa self-assigned this Oct 24, 2023
@inokawa
Copy link
Owner Author

inokawa commented Nov 19, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant