-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup. Remove some deprecated type synonyms. #3205
Conversation
1267d40
to
d2f7926
Compare
d2f7926
to
e06928e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few nitpicks
d82b39b
to
e06928e
Compare
sorry for the force pushes, I accidentally pushed some changes onto your branch and then undid them :s |
e06928e
to
27fdb6b
Compare
No worries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic! 🙌
27fdb6b
to
1ed58c9
Compare
Description
This is just a cleanup PR. It takes care of a few things:
ValidatedTx
,TxOut
,TxBody
,TxSeq
,Script
,Value
,PParamDelta
.as Core
qualified import is not needed in most places due to removal of above deprcationsCrypto
qualified asCC
. It no longer conflicts with recently renamedEraCrypto
Cardano.Ledger.Shelley.Metadata
module toCardano.Ledger.Shelley.TxAuxData
There aren't really any semantic changes here. Just the cleanup
Checklist
scripts/ormolise.sh