This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[DEVOPS-632] ci: Build benchmarks in hydra and buildkite #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
force-pushed
the
rvl/build-benchmarks
branch
4 times, most recently
from
5114405
to
cf0ba8f
Compare
jmitchell
approved these changes
Jun 6, 2018
| @@ -10,6 +10,7 @@ in | |||
| , forceDontCheck ? false | |||
| , enableProfiling ? false | |||
| , enableDebugging ? false | |||
| , enableBenchmarks ? true | |||
There was a problem hiding this comment.
You asked whether this is a good default. Yes, it makes sense. Devs should get feedback about benchmarks that don't build correctly, but we shouldn't spend time running all the benchmarks every build by default.
default.nix
Outdated
| # enableBenchmarks argument is supplied. | ||
| withBenchmarks = drv: if enableBenchmarks | ||
| then doBenchmark (appendConfigureFlag drv "--enable-benchmarks") | ||
| else drv; |
There was a problem hiding this comment.
Can we call this buildWithBenchmarks to clarify it has to do with building the benchmarks rather than running them? When looking at the withBenchmarks call sites people may mistakenly think the latter.
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Benchmarks were not being built in CI and therefore were getting broken without anyone noticing.
This enables building (but not running) of benchmarks.
The CI for this PR should successfully fail because it doesn't include the merge of #3005.
I would like some feedback about the defaults in nix. Should the
enableBenchmarksarg default to true or false? Should there be separate derivations with benchmarks enabled?Linked issue
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-632
Type of change
Developer checklist
QA Steps
Screenshots