Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CDEC-370] Enable benchmarks for all packages with benchmarks #3085

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

ruhatch
Copy link
Contributor

@ruhatch ruhatch commented Jun 13, 2018

Description

#3008 added the buildWithBenchmarks function to default.nix, but only enabled it for cardano-sl-wallet-new. This enables it for all packages with benchmark sections in their cabal file.

Linked issue

CDEC-370

Type of change

  • [~] 🐞 Bug fix (non-breaking change which fixes an issue)
  • [~] 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • [~] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • [~] I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@ruhatch
Copy link
Contributor Author

ruhatch commented Jun 13, 2018

Expecting this to fail CI first time because the cardano-sl benchmark should be broken.

@ruhatch ruhatch force-pushed the ruhatch/CDEC-370 branch 3 times, most recently from 2e9c443 to 75088e2 Compare June 14, 2018 17:12
Copy link
Contributor

@avieth avieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in principle but I wonder if enabling benchmarks will cause CI to take a prohibitively long time (it's already ridiculously long).

Is it possible to just build the benchmarks but not run them?

@ruhatch
Copy link
Contributor Author

ruhatch commented Jun 14, 2018

This is supposed to not run them apparently (default behaviour from nixpkgs)

@ruhatch ruhatch merged commit d22ecae into develop Jun 14, 2018
@ruhatch ruhatch deleted the ruhatch/CDEC-370 branch June 14, 2018 23:17
@erikd
Copy link
Member

erikd commented Jun 16, 2018

@avieth Just to confirm, this is supposed to build but not run benchmarks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants