Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-2099] post tx without blocking on mempool full in light mode #3418

Merged

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Aug 1, 2022

  • added support for post transactions in light mode
  • added error forwarding on mempool (HTTP 425) error from blockfrost

Issue Number

ADP-2099

@paolino paolino force-pushed the light-mode/ADP-2099/post-tx-no-block-on-mempool-full branch from a8e0366 to 7fc8c6c Compare August 2, 2022 08:06
@paolino paolino marked this pull request as ready for review August 2, 2022 08:12
@paolino paolino requested a review from Unisay August 2, 2022 08:12
@paolino paolino force-pushed the light-mode/ADP-2099/post-tx-no-block-on-mempool-full branch 2 times, most recently from 158e60c to 6f2797b Compare August 2, 2022 10:02
@paolino
Copy link
Collaborator Author

paolino commented Aug 2, 2022

CI failed:

To rerun use: --match "/Cardano.Wallet.Api.Server.Tls/TLS Client Authentication/Deny client with wrong certificate if TLS is enabled/"

@paolino paolino force-pushed the light-mode/ADP-2099/post-tx-no-block-on-mempool-full branch from 6f2797b to 5423b2e Compare August 3, 2022 07:37
@paolino
Copy link
Collaborator Author

paolino commented Aug 4, 2022

CI failed:

To rerun use: --match "/Cardano.Wallet.Api.Server.Tls/TLS Client Authentication/Deny client with wrong certificate if TLS is enabled/"

@paolino paolino changed the title post tx without blocking on mempool full in light mode [ADP-2099] post tx without blocking on mempool full in light mode Aug 4, 2022
@paolino
Copy link
Collaborator Author

paolino commented Aug 4, 2022

CI failed:

To rerun use: --match "/Cardano.Wallet.Api.Server.Tls/TLS Client Authentication/Deny client with wrong certificate if TLS is enabled/"

1 similar comment
@paolino
Copy link
Collaborator Author

paolino commented Aug 4, 2022

CI failed:

To rerun use: --match "/Cardano.Wallet.Api.Server.Tls/TLS Client Authentication/Deny client with wrong certificate if TLS is enabled/"

Copy link
Contributor

@Unisay Unisay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

@paolino paolino force-pushed the light-mode/ADP-2099/post-tx-no-block-on-mempool-full branch 2 times, most recently from a653b09 to 2c9a393 Compare August 9, 2022 15:06
@paolino paolino requested a review from Unisay August 9, 2022 15:09
@paolino paolino force-pushed the light-mode/ADP-2099/post-tx-no-block-on-mempool-full branch from 2c9a393 to 5f8e221 Compare August 11, 2022 07:43
@paolino paolino force-pushed the light-mode/ADP-2099/post-tx-no-block-on-mempool-full branch from 5f8e221 to 8807103 Compare August 11, 2022 08:58
@paolino
Copy link
Collaborator Author

paolino commented Aug 11, 2022

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 11, 2022
3418: [ADP-2099] post tx without blocking on mempool full in light mode r=paolino a=paolino




- [x] added support for post transactions in light mode
- [x] added error forwarding on mempool (HTTP 425) error from blockfrost


### Issue Number
ADP-2099


Co-authored-by: paolo veronelli <paolo.veronelli@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 11, 2022

Build failed:

To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_SMASH_01 - fetching metadata from SMASH works with delisted pools/"

Randomized with seed 274200483

#2331

@paolino
Copy link
Collaborator Author

paolino commented Aug 11, 2022

bors try

iohk-bors bot added a commit that referenced this pull request Aug 11, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 11, 2022

try

Build failed:

  src/Test/Integration/Scenario/API/Shelley/TransactionsNew.hs:2481:26: 
  1) API Specifications, NEW_SHELLEY_TRANSACTIONS, TRANS_NEW_JOIN_01a - Can join stakepool, rejoin another and quit
       While verifying value:
         ( Status
             { statusCode = 200
             , statusMessage = "OK"
             }
         , Right
             ( ApiWallet
                 { id = ApiT
                     ( WalletId { getWalletId = acd4982644936f2c4c8b0e61115d89d17606a771 } )
                 , addressPoolGap = ApiT
                     ( AddressPoolGap
                         { getAddressPoolGap = 20 }
                     )
                 , balance = ApiWalletBalance
                     { available = Quantity 8441860
                     , total = Quantity 10011287
                     , reward = Quantity 1569427
                     }
                 , assets = ApiWalletAssetsBalance
                     { available = ApiT
                         ( TokenMap
                             ( fromList [] )
                         )
                     , total = ApiT
                         ( TokenMap
                             ( fromList [] )
                         )
                     }
                 , delegation = ApiWalletDelegation
                     { active = ApiWalletDelegationNext
                         { status = Delegating
                         , target = Just
                             ( ApiT
                                 ( PoolId
                                     { getPoolId = "´WhÁ¢ÚKÑ>¼ª\x1e¥\x14\x8í£\x1dÌ!v\ËÔ\x7Í©ò" }
                                 )
                             )
                         , changesAt = Nothing
                         }
                     , next = []
                     }
                 , name = ApiT
                     ( WalletName
                         { getWalletName = "Empty Wallet" }
                     )
                 , passphrase = Just
                     ( ApiWalletPassphraseInfo 2022-08-11 16:44:14.803023831 UTC )
                 , state = ApiT Ready
                 , tip = ApiBlockReference
                     { absoluteSlotNumber = ApiT
                         ( SlotNo 4211 )
                     , slotId = ApiSlotId
                         { epochNumber = ApiT
                             ( EpochNo
                                 { unEpochNo = 52 }
                             )
                         , slotNumber = ApiT
                             ( SlotInEpoch
                                 { unSlotInEpoch = 51 }
                             )
                         }
                     , time = 2022-08-11 16:47:32.2 UTC
                     , block = ApiBlockInfo
                         ( Quantity 2083 )
                     }
                 }
             )
         )
       
       Waited longer than 90s to resolve action: "Wallet has consumed rewards".
       expected: Quantity 0
        but got: Quantity 1569427

@paolino
Copy link
Collaborator Author

paolino commented Aug 12, 2022

bors try

iohk-bors bot added a commit that referenced this pull request Aug 12, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 12, 2022

try

Build failed:

To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_LIST_01 - List stake pools/pools have the correct retirement information/"

Randomized with seed 2059232610

@paolino
Copy link
Collaborator Author

paolino commented Aug 12, 2022

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 12, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 9c869db into master Aug 12, 2022
@iohk-bors iohk-bors bot deleted the light-mode/ADP-2099/post-tx-no-block-on-mempool-full branch August 12, 2022 10:56
WilliamKingNoel-Bot pushed a commit that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants