Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-1663] add wallet-mode field in /network/information/ endpoint #3419

Merged
merged 4 commits into from
Aug 9, 2022

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Aug 2, 2022

  • added a wallet_mode field to the ApiNetworkInformation
  • retrieved the Node vs Light value from the lightSync value in the NetworkLayer
  • updated OpenAPI documentation to reflect the addition
  • updated golden test for ApiNetworkInformation.json

Comments

Issue Number

ADP-1663

@paolino paolino changed the title add openapi specification for the new wallet-mode field add wallet-mode field in /network/information/ endpoint Aug 2, 2022
@paolino paolino force-pushed the light-mode/ADP-1663/expose-wallet-mode branch from d1004f0 to f470da1 Compare August 2, 2022 14:25
@paolino paolino requested a review from Unisay August 2, 2022 14:31
@paolino paolino marked this pull request as ready for review August 2, 2022 14:31
@paolino paolino force-pushed the light-mode/ADP-1663/expose-wallet-mode branch from f470da1 to f1e6d7f Compare August 2, 2022 15:23
@paolino
Copy link
Collaborator Author

paolino commented Aug 3, 2022

CI failed:

To rerun use: --match "/Cardano.Wallet.Api.Server.Tls/TLS Client Authentication/Deny client with wrong certificate if TLS is enabled/"

@paolino paolino force-pushed the light-mode/ADP-1663/expose-wallet-mode branch from c6ea664 to ba1a99d Compare August 3, 2022 07:39
@paolino
Copy link
Collaborator Author

paolino commented Aug 4, 2022

CI failed:

To rerun use: --match "/Cardano.Wallet.Api.Server.Tls/TLS Client Authentication/Deny client with wrong certificate if TLS is enabled/"

@paolino paolino force-pushed the light-mode/ADP-1663/expose-wallet-mode branch from ba1a99d to f964ddf Compare August 4, 2022 10:15
@paolino paolino changed the title add wallet-mode field in /network/information/ endpoint [ADP-1663] add wallet-mode field in /network/information/ endpoint Aug 4, 2022
@paolino paolino requested a review from Unisay August 4, 2022 10:19
@paolino paolino force-pushed the light-mode/ADP-1663/expose-wallet-mode branch 3 times, most recently from 6c8c4fc to d9f23ed Compare August 5, 2022 15:28
@paolino paolino force-pushed the light-mode/ADP-1663/expose-wallet-mode branch from d9f23ed to 347ee7d Compare August 9, 2022 07:45
@paolino
Copy link
Collaborator Author

paolino commented Aug 9, 2022

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 9, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 1f8288d into master Aug 9, 2022
@iohk-bors iohk-bors bot deleted the light-mode/ADP-1663/expose-wallet-mode branch August 9, 2022 13:47
WilliamKingNoel-Bot pushed a commit that referenced this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants