[DDW-56, DDW-6, DDW-50, DDW-47] Bech32 adresses validation (#1902)

* [DDW-56] Introduce Bech32 address validation

* [DDW-56] Add yarn.lock bech32 entry

* [DDW-56] Configure Legacy wallet send / receive tabs

* [DDW-56] Remove Legacy topbar notifications outside ITN

* [DDW-56] Code cleanup

* [DDW-56] Fix flow issues and run prettier

* [DDW-56] Remove bech32 byron address validation

* [DDW-56] Remove Network info sidebar label from mainnet

* [DDW-56] Code cleanup

* [DDW-56] Restore Byron wallet Receive screen with address creation

* [DDW-56] Add missing Byron receive screen translations

* [DDW-56] Code cleanup and improvements

* [DDW-56] Add address creation actions and faked api method

* [DDW-56] Update wallet receive storybook stories

* [DDW-56] Add byron address creation request and address types improvement

* [DDW-56] Update api methodes logging function

* [DDW-56] Add full staging iconset

* [DDW-56] Code and Flow improvements

* [DDW-56] Remove mainnet sidebar label rejection

* [DDW-56] Wallet settings change / create wallet password improvement

* [DDW-56] CHANGELOG update

* [DDW-56] Improve CHANGELOG

* [DDW-56] Remove unnecesarry isLegacy declaration and password encryption

* [DDW-56] Improve address validation

* [DDW-56] Create Byron wallet address request improvement due to api documentation update

* [DDW-56] Removing wallet specific from Navigation component

* [DDW-64] Code improvements

* [DDW-56] Adjustments

Co-authored-by: Nikola Glumac <niglumac@gmail.com>
Co-authored-by: Danilo Prates <daniloprates@gmail.com>

CHANGELOG.md

@@ -10,6 +10,9 @@ Changelog
 - Added support for `cardano-node` "Selfnode" network ([PR 1897](https://github.com/input-output-hk/daedalus/pull/1897))
 - Enabled Byron wallet creation for Haskell node builds ([PR 1895](https://github.com/input-output-hk/daedalus/pull/1895))
 - Enabled all Mainnet Daedalus features for Byron wallets for Haskell node builds ([PR 1895](https://github.com/input-output-hk/daedalus/pull/1895))
+- Enabled changing spending password in "Wallet settings" for Haskell node builds ([PR 1902](https://github.com/input-output-hk/daedalus/pull/1902))
+- Enabled "Send" feature for Haskell node builds ([PR 1902](https://github.com/input-output-hk/daedalus/pull/1902))
+- Disabled transfer funds notification for Haskell node builds ([PR 1902](https://github.com/input-output-hk/daedalus/pull/1902))
 - Disabled Shelley wallets and delegation features for Haskell node builds ([PR 1895](https://github.com/input-output-hk/daedalus/pull/1895))
 - Disabled "Data layer migration" notification for Haskell node builds ([PR 1895](https://github.com/input-output-hk/daedalus/pull/1895))
 - Disabled "Paper wallet certificate" creation for Haskell node builds ([PR 1895](https://github.com/input-output-hk/daedalus/pull/1895))
@@ -23,6 +26,7 @@ Changelog
 
 ### Chores
 
+- Updated Byron Haskell address validation ([PR 1902](https://github.com/input-output-hk/daedalus/pull/1902))
 - Updated test configuration to cover Byron features only ([PR 1895](https://github.com/input-output-hk/daedalus/pull/1895))
 - Optimized e2e tests ([PR 1874](https://github.com/input-output-hk/daedalus/pull/1874))
 - Updated `react-polymorph` dependency ([PR 1882](https://github.com/input-output-hk/daedalus/pull/1882))

source/renderer/app/actions/addresses-actions.js

@@ -0,0 +1,12 @@
+// @flow
+import Action from './lib/Action';
+
+// ======= ADDRESSES ACTIONS =======
+
+export default class AddressesActions {
+  createByronWalletAddress: Action<{
+    walletId: string,
+    passphrase: string,
+  }> = new Action();
+  resetErrors: Action<any> = new Action();
+}

source/renderer/app/actions/index.js

@@ -1,4 +1,5 @@
 // @flow
+import AddressesActions from './addresses-actions';
 import AppActions from './app-actions';
 import DialogsActions from './dialogs-actions';
 import NetworkStatusActions from './network-status-actions';
@@ -15,6 +16,7 @@ import WalletSettingsActions from './wallet-settings-actions';
 import WindowActions from './window-actions';
 
 export type ActionsMap = {
+  addresses: AddressesActions,
   app: AppActions,
   dialogs: DialogsActions,
   networkStatus: NetworkStatusActions,
@@ -32,6 +34,7 @@ export type ActionsMap = {
 };
 
 const actionsMap: ActionsMap = {
+  addresses: new AddressesActions(),
   app: new AppActions(),
   dialogs: new DialogsActions(),
   networkStatus: new NetworkStatusActions(),

source/renderer/app/api/addresses/requests/createByronWalletAddress.js

@@ -0,0 +1,28 @@
+// @flow
+import type { RequestConfig } from '../../common/types';
+import type { Address } from '../types';
+import { request } from '../../utils/request';
+import { getRawWalletId } from '../../utils';
+
+export type CreateAddressParams = {
+  walletId: string,
+  passphrase: string,
+  addressIndex?: number,
+};
+
+export const createByronWalletAddress = (
+  config: RequestConfig,
+  { passphrase, addressIndex, walletId }: CreateAddressParams
+): Promise<Address> => {
+  let data = { passphrase };
+  data = addressIndex ? { ...data, address_index: addressIndex } : data;
+  return request(
+    {
+      method: 'POST',
+      path: `/v2/byron-wallets/${getRawWalletId(walletId)}/addresses`,
+      ...config,
+    },
+    {},
+    data
+  );
+};

source/renderer/app/api/addresses/types.js

@@ -17,3 +17,11 @@ export type GetAddressesRequest = {
   isLegacy: boolean,
   queryParams?: GetAddressesRequestQueryParams,
 };
+
+// Byron related types
+
+export type CreateByronWalletAddressRequest = {
+  walletId: string,
+  passphrase: string,
+  addressIndex?: number,
+};

source/renderer/app/api/api.js

@@ -18,6 +18,7 @@ import WalletAddress from '../domains/WalletAddress';
 
 // Addresses requests
 import { getAddresses } from './addresses/requests/getAddresses';
+import { createByronWalletAddress } from './addresses/requests/createByronWalletAddress';
 
 // Network requests
 import { getNetworkInfo } from './network/requests/getNetworkInfo';
@@ -103,7 +104,11 @@ import {
 import { FORCED_WALLET_RESYNC_WAIT } from '../config/timingConfig';
 
 // Addresses Types
-import type { Address, GetAddressesRequest } from './addresses/types';
+import type {
+  Address,
+  GetAddressesRequest,
+  CreateByronWalletAddressRequest,
+} from './addresses/types';
 
 // Common Types
 import type { RequestConfig } from './common/types';
@@ -722,6 +727,31 @@ export default class AdaApi {
     }
   };
 
+  createAddress = async (
+    request: CreateByronWalletAddressRequest
+  ): Promise<WalletAddress> => {
+    logger.debug('AdaApi::createAddress called', {
+      parameters: filterLogData(request),
+    });
+    const { addressIndex, walletId, passphrase: passwordString } = request;
+    const passphrase = passwordString || '';
+    try {
+      const address: Address = await createByronWalletAddress(this.config, {
+        passphrase,
+        walletId,
+        addressIndex,
+      });
+      logger.debug('AdaApi::createAddress success', { address });
+      return _createAddressFromServerData(address);
+    } catch (error) {
+      logger.error('AdaApi::createAddress error', { error });
+      if (error.message === 'CannotCreateAddress') {
+        throw new IncorrectSpendingPasswordError();
+      }
+      throw new GenericApiError();
+    }
+  };
+
   deleteTransaction = async (
     request: DeleteTransactionRequest
   ): Promise<void> => {
@@ -1753,6 +1783,7 @@ const _createWalletFromServerData = action(
       reward: walletRewardAmount,
       passwordUpdateDate:
         passphraseLastUpdatedAt && new Date(passphraseLastUpdatedAt),
+      hasPassword: passphraseLastUpdatedAt !== null,
       syncState,
       isLegacy,
       delegatedStakePoolId,

source/renderer/app/components/layout/TopBar.js

@@ -35,6 +35,7 @@ export default class TopBar extends Component<Props> {
       onWalletAdd,
       onLearnMore,
     } = this.props;
+    const { isIncentivizedTestnet } = global;
 
     const topBarStyles = classNames([
       styles.topBar,
@@ -44,6 +45,7 @@ export default class TopBar extends Component<Props> {
     const hasLegacyNotification =
       activeWallet &&
       activeWallet.isLegacy &&
+      isIncentivizedTestnet &&
       activeWallet.amount.gt(0) &&
       !activeWallet.isRestoring &&
       ((hasRewardsWallets && onTransferFunds) || onWalletAdd);

source/renderer/app/components/navigation/NavDropdown.js

@@ -14,7 +14,6 @@ type Props = {
   options: Array<{
     value: number | string,
     label: string,
-    isLegacy?: boolean,
   }>,
   onChange: Function,
   hasNotification?: boolean,
@@ -32,10 +31,6 @@ export default class NavDropdown extends Component<Props> {
       activeItem,
       hasNotification,
     } = this.props;
-    let filteredOptions = options;
-    if (options) {
-      filteredOptions = options.filter(option => !option.isLegacy);
-    }
     const componentStyles = classnames([
       styles.component,
       hasNotification ? styles.hasNotification : null,
@@ -58,7 +53,7 @@ export default class NavDropdown extends Component<Props> {
           optionRenderer={o => (
             <div className={styles.optionLabel}>{o.label}</div>
           )}
-          items={filteredOptions}
+          items={options}
           activeItem={options.find(o => o.value === activeItem)}
           noArrow
           optionHeight={32}

source/renderer/app/components/navigation/Navigation.js

@@ -10,21 +10,21 @@ export type NavButtonProps = {
   id: string,
   label: string,
   icon?: string,
-  isLegacy?: boolean,
   hasNotification?: boolean,
 };
 
 export type NavDropdownProps = {
   ...$Exact<NavButtonProps>,
   type: 'dropdown',
-  options: Array<{ value: number | string, label: string, isLegacy?: boolean }>,
+  options: Array<{ value: number | string, label: string }>,
   hasNotification?: boolean,
 };
 
 type Props = {
   activeItem: string,
   isActiveNavItem?: Function,
   onNavItemClick: Function,
+  isLegacy?: boolean,
   items: Array<NavButtonProps | NavDropdownProps>,
 };
 
@@ -47,46 +47,35 @@ export default class Navigation extends Component<Props> {
       onNavItemClick,
       activeItem,
       items,
+      isLegacy,
     } = this.props;
+    const { isIncentivizedTestnet } = global;
+
     return (
       <div className={styles.component}>
-        {items.map(({ id, icon, label, isLegacy, hasNotification, ...item }) =>
-          item.type === 'dropdown'
-            ? (!isLegacy && (
-                <NavDropdown
-                  key={id}
-                  label={label}
-                  icon={icon}
-                  isActive={isActiveNavItem(id, item)}
-                  onChange={i => onNavItemClick(i)}
-                  isLegacy={isLegacy}
-                  activeItem={activeItem}
-                  options={item.options}
-                  hasNotification={hasNotification}
-                />
-              )) ||
-              (isLegacy && (
-                <NavButton
-                  key={id}
-                  className={id}
-                  label={label}
-                  icon={icon}
-                  isActive={isActiveNavItem(id, item)}
-                  onClick={() => onNavItemClick(id)}
-                  hasNotification={hasNotification}
-                />
-              ))
-            : !isLegacy && (
-                <NavButton
-                  key={id}
-                  className={id}
-                  label={label}
-                  icon={icon}
-                  isActive={isActiveNavItem(id, item)}
-                  onClick={() => onNavItemClick(id)}
-                  hasNotification={hasNotification}
-                />
-              )
+        {items.map(({ id, icon, label, hasNotification, ...item }) =>
+          item.type === 'dropdown' && !(isIncentivizedTestnet && isLegacy) ? (
+            <NavDropdown
+              key={id}
+              label={label}
+              icon={icon}
+              isActive={isActiveNavItem(id, item)}
+              onChange={i => onNavItemClick(i)}
+              activeItem={activeItem}
+              options={item.options}
+              hasNotification={hasNotification}
+            />
+          ) : (
+            <NavButton
+              key={id}
+              className={id}
+              label={label}
+              icon={icon}
+              isActive={isActiveNavItem(id, item)}
+              onClick={() => onNavItemClick(id)}
+              hasNotification={hasNotification}
+            />
+          )
         )}
       </div>
     );