New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-256] No disk space overlay #1157
[DDW-256] No disk space overlay #1157
Conversation
…-for-no-diskspace-error
…-for-no-diskspace-error
This reverts commit ff229f8.
…-for-no-diskspace-error
…-for-no-diskspace-error
…screen after displaying not-enough-disk-space overlay
…isk-space, Fix failing acceptance tests
We'll need to improve this feature...
These intervals should be updated on every disk-space-check run. This means that as free disk space decreases and our checks notice this happening they will start running more frequently. cc @daniloprates @DominikGuzei @darko-mijic @DmitriiGaico |
Is checking the disk space such a costly operation or why do we need 10 different intervals? |
@DominikGuzei as I have pointed out in my comment - this was just a suggestion. |
i was just asking because you have proposed a complicated logic for the interval based on free disc space … now i wondered why 😉 |
I still think we should have it like that - just simpler ;) |
@DominikGuzei I have added only one more interval: 23de0d7 Here's the new setup:
|
…-for-no-diskspace-error
Looks good @nikolaglumac 👍 |
bors r+ |
1157: [DDW-256] No disk space overlay r=DominikGuzei a=daniloprates This PR Implements better handling for no-diskspace error Low disk space check solution: - Daedalus checks for free disk space on startup and every 10 minutes while running - if this space is lower than 2 GB - 10% we don't start the node or stop it if it is running, we show the red screen explaining that Daedalus requires at least 2 GB of free space but we strongly recommend having more free space (as recommended by OS manufacturer) - while on red screen, we check for free disk space every 10 seconds - we hide the red screen and restart node when disk space is more than 2 GB - final check intervals are implemented as follows: | Available disk space | Check interval | |----------------------|:--------:| | >= 0 && < 2 GB | 10 sec | | >= 2 && < 4 GB | 1 min | | >= 4 GB | 10 min | ## Todo: - [x] No disk space overlay - [x] Container functions and variables - [x] IPC communication - [x] Detect "no space" error and suppress alert - [x] Calculate space required - [x] Stop/Start Cardano - [x] English copy - @darko-mijic - [x] Japanese translation - @darko-mijic - [x] New copy with the meeting conclusion changes - @darko-mijic - [x] New Japanese translation - @darko-mijic - [x] Implement acceptance tests - [x] Implement dynamic disk-space-check intervals ## Screenshots: ### Before ![image](https://user-images.githubusercontent.com/1504716/47876280-aafa6f80-ddf7-11e8-9989-b6850891531c.png) ### After ![image](https://user-images.githubusercontent.com/1504716/49522366-a7428880-f88e-11e8-884b-faac8e1394db.png) --- ## Review Checklist: ### Basics - [ ] PR is updated to the most recent version of target branch (and there are no conflicts) - [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes - [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub - [ ] Automated tests: All acceptance tests are passing (`yarn run test`) - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`) - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds) - [ ] There are no *flow* errors or warnings (`yarn run flow:test`) - [ ] There are no *lint* errors or warnings (`yarn run lint`) - [ ] Text changes are proofread and approved (Jane Wild) - [ ] There are no missing translations (running `yarn run manage:translations` produces no changes) - [ ] UI changes look good in all themes (Alexander Rukin) - [ ] Storybook works and no stories are broken (`yarn run storybook`) - [ ] In case of dependency changes `yarn.lock` file is updated ### Code Quality - [ ] Important parts of the code are properly documented and commented - [ ] Code is properly typed with flow - [ ] React components are split-up enough to avoid unnecessary re-rendering - [ ] Any code that only works in Electron is neatly separated from components ### Testing - [ ] New feature / change is covered by acceptance tests - [ ] All existing acceptance tests are still up-to-date - [ ] New feature / change is covered by Daedalus Testing scenario - [ ] All existing Daedalus Testing scenarios are still up-to-date ### After Review: - [ ] Merge PR - [ ] Delete source branch - [ ] Move ticket to `done` on the Youtrack board Co-authored-by: Danilo Prates <daniloprates@gmail.com>
This PR Implements better handling for no-diskspace error
Low disk space check solution:
Todo:
Screenshots:
Before
After
Review Checklist:
Basics
yarn run test
)yarn run dev
)yarn run package
/ CI builds)yarn run flow:test
)yarn run lint
)yarn run manage:translations
produces no changes)yarn run storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review:
done
on the Youtrack board