Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-465] Multi-language installers #1287

Closed

Conversation

thedanheller
Copy link
Member

@thedanheller thedanheller commented Jan 28, 2019

This PR implements multi-language installers.

Todo:

  • Japanese translation for Windows installer
  • Japanese translation for macOS installer
  • Create translation files to be used by the installers (example)
  • Implement translations for Windows Installer:
{Daedalus} Uninstaller {$Version}
Start Menu Shortcuts
{Daedalus} is running. It needs to be fully shut down before running the installer!
  • Implement translations for macOS Installer

Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@thedanheller thedanheller self-assigned this Jan 28, 2019
@cleverca22 cleverca22 force-pushed the feature/ddw-465-multi-language-installers branch 9 times, most recently from f31b106 to 3708e3d Compare January 31, 2019 13:49
@cleverca22
Copy link
Contributor

screenshot_2019-01-31_09-45-37

currently, it doesnt ask for a language when installing
but if you set the entire OS to japanese, then the installer is also japanese

@cleverca22 cleverca22 force-pushed the feature/ddw-465-multi-language-installers branch from 3708e3d to bb070ad Compare January 31, 2019 14:06
@thedanheller
Copy link
Member Author

screenshot_2019-01-31_09-45-37

currently, it doesnt ask for a language when installing
but if you set the entire OS to japanese, then the installer is also japanese

@cleverca22 the same happens to the MacOS installer

@cleverca22 cleverca22 force-pushed the feature/ddw-465-multi-language-installers branch 2 times, most recently from b6101b0 to 03aff00 Compare February 6, 2019 09:42
@nikolaglumac nikolaglumac removed the WIP label Feb 6, 2019
@nikolaglumac nikolaglumac self-requested a review February 6, 2019 09:56
@cleverca22 cleverca22 force-pushed the feature/ddw-465-multi-language-installers branch 9 times, most recently from d08465a to cef75fe Compare February 7, 2019 00:19
@cleverca22 cleverca22 force-pushed the feature/ddw-465-multi-language-installers branch 2 times, most recently from a554c9b to 6d5d0be Compare February 7, 2019 04:50
@cleverca22 cleverca22 force-pushed the feature/ddw-465-multi-language-installers branch 4 times, most recently from bcf2bdf to 33bd92b Compare February 7, 2019 20:53
@cleverca22 cleverca22 force-pushed the feature/ddw-465-multi-language-installers branch from 33bd92b to d88a3e7 Compare February 8, 2019 04:03
@nikolaglumac
Copy link
Contributor

nikolaglumac commented Feb 10, 2019

@cleverca22 are we there yet? :)

@DominikGuzei
Copy link
Member

@daniloprates @cleverca22 what's the state of this PR? Should / did we hand it over to QA?

@nikolaglumac
Copy link
Contributor

This PR is to be replaced by: #1298
@cleverca22 can you confirm this?

@nikolaglumac
Copy link
Contributor

Closing this PR unmerged in favour of #1298

@nikolaglumac nikolaglumac deleted the feature/ddw-465-multi-language-installers branch February 19, 2019 10:39
@nikolaglumac nikolaglumac mentioned this pull request Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants