[DDW-581] Replace ada symbol images with unicode character #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedanheller
requested review from
DominikGuzei and
nikolaglumac
and removed request for
DominikGuzei
|
@daniloprates we need @a-rukin to approve this! Please align with him and perhaps do a live demo call 🙏 |
|
I'd suggest using ADA as a unicode symbol only in the smallest pending/outgoing transactions with a space (' ') before. Rest look too different from an original ADA symbol. Sorry 😢 |
thedanheller
changed the title
|
|
|
What about transactions and the send screen (including transaction confirmation dialog)? There we use ‘ada’ word - wouldn’t it be better to use ada symbol instead? cc @darko-mijic |
|
Examples would help understanding if it works |
|
|
|
@a-rukin @nikolaglumac @darko-mijic I like it
|
|
Looks good 👍 |
|
What about transactions tab? |
|
@a-rukin @nikolaglumac @darko-mijic Loading screen
Summary tab
Transactions (Summary and Transactions tabs)
Wallet Send screen
|
|
@darko-mijic what do you say: #1317 (comment) |
|
Looks great, except for the unicode symbol after the transaction amount … i think that's too thick and probably would be better as
|
DominikGuzei
approved these changes
Feb 27, 2019
|
@daniloprates @DominikGuzei @a-rukin I have replaced "ADA" text with this new UTF symbol in few places: |
|
Left menu is ok, but those in a middle looks awkward |
|
@a-rukin fixed: |
|
@DominikGuzei fixed: |
nikolaglumac
changed the title
iohk-bors
bot
deleted the
feature/ddw-581-check-if-we-can-replace-ada-symbol-images-with-unicode-character
branch
24 tasks
iohk-bors bot
added a commit
that referenced
this pull request
Mar 6, 2019
1336: [DDW-581] Revert ada symbol images with unicode character r=nikolaglumac a=daniloprates This PR reverts part of [PR 1317](#1317), which replaced ada symbol images with unicode character. --- ## Review Checklist: ### Basics - [ ] PR is updated to the most recent version of target branch (and there are no conflicts) - [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes - [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub - [ ] Automated tests: All acceptance tests are passing (`yarn run test`) - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`) - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds) - [ ] There are no *flow* errors or warnings (`yarn run flow:test`) - [ ] There are no *lint* errors or warnings (`yarn run lint`) - [ ] Text changes are proofread and approved (Jane Wild) - [ ] There are no missing translations (running `yarn run manage:translations` produces no changes) - [ ] UI changes look good in all themes (Alexander Rukin) - [ ] Storybook works and no stories are broken (`yarn run storybook`) - [ ] In case of dependency changes `yarn.lock` file is updated ### Code Quality - [ ] Important parts of the code are properly documented and commented - [ ] Code is properly typed with flow - [ ] React components are split-up enough to avoid unnecessary re-rendering - [ ] Any code that only works in Electron is neatly separated from components ### Testing - [ ] New feature / change is covered by acceptance tests - [ ] All existing acceptance tests are still up-to-date - [ ] New feature / change is covered by Daedalus Testing scenario - [ ] All existing Daedalus Testing scenarios are still up-to-date ### After Review: - [ ] Merge PR - [ ] Delete source branch - [ ] Move ticket to `done` on the Youtrack board Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Nikola Glumac <niglumac@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces ada symbol images with unicode character.
Screenshots:
SVG
UTF
SVG
UTF - Light
UTF - Thin
Review Checklist:
Basics
yarn run test)yarn run dev)yarn run package/ CI builds)yarn run flow:test)yarn run lint)yarn run manage:translationsproduces no changes)yarn run storybook)yarn.lockfile is updatedCode Quality
Testing
After Review:
doneon the Youtrack board