New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.14.0 #1496
Merged
Merged
Release/0.14.0 #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iple' into feature/ddw-673-ui-stake-pool-list-dynamic-tooltip
…legacy badge selection style
…f github.com:input-output-hk/daedalus into feature/ddw-648-ui-move-funds-from-legacy-wallet-cta
…gacy to stakePools
…-optimize-themeing-colors [DDW-604] Unify and Optimize Themeing Colors
# Conflicts: # CHANGELOG.md
* [DDW-757] Introduce yellow / white / dark-cardano themes base setup * [DDW-757] Add new themes to Settings page * [DDW-757] Run translations manager * [DDW-757] Add missing config for new themes create/update and theme images * [DDW-757] Generate css variables for new themes and yellow theme overrides * [DDW-757] Adjusts buttons colors in all states, and input/select border colors * [DDW-757] Auto-updates defaultMessages.json * [DDW-757] Fixes delegation icon in SideBar to use fill/stroke color in CSS vars * [DDW-757] Fixes delegation-progress icon in SideBar to use fill/stroke color in CSS vars * [DDW-757] Fixes create paper wallet icon in SideBar to use fill/stroke color in CSS vars * [DDW-757] Yellow theme fine tuning and storybook menu new themes selection * [DDW-757] Fix dark cardano theme config and vars creation * [DDW-757] Introduce Dark-Cardano theme partial varibles override * [DDW-757] Yellow theme styles improvements * [DDW-757] Generating new additional variables for all themes * [DDW-757] Introduce basic layout variables overrides for White theme * [DDW-757] Small color improvements for BigDialogButtons, StakePool cards and tooltips, delegation dropdowns on Yellow theme * [DDW-757] Dark-Blue theme border color on stake pool boxes fix * [DDW-757] Support icon for yellow theme * [DDW-757] Fix Support icon disappearing * [DDW-757] Main background color change * [DDW-757] Yellow theme - about window fixes * [DDW-757] Stories to get the current theme and dark icon for white theme * [DDW-757] Yellow theme - about window overlay color * [DDW-757] Add MINT variations to White theme and settings page translation improvement * [DDW-757] Adding new theme images for setting page * [DDW-757] White overrides - WIP * [DDW-757] Theme buttons better arrangement * [DDW-757] Finalizing Yellow theme by resolving requested changes * [DDW-757] Run prettier * [DDW-757] UTXO graph colors improvement and options list bg color * [DDW-757] Fix copy notification text color * [DDW-757] Fix dropdown bg colors * [DDW-757] Fix support request hover * [DDW-757] Update dark cardano theme * [DDW-757] White theme - WIP * [DDW-757] White theme - Block consolidation done * [DDW-757] White theme - Paper Wallet * [DDW-757] White theme - Transactions * [DDW-757] Matches Block Consolidation screen to mockups in fine detail * [DDW-757] Imports taller, thinner cross svg for use in About/Block Consolidation screens * [DDW-757] Replaces hard coded fill value with CSS variable * [DDW-757] Uses thinner cross in About.js * [DDW-757] Handles active/pressed button state on Block Consolidation screen * [DDW-757] Color value adjustments in all theme files * [DDW-757] Auto update in defaultMessages.json * [DDW-757] Fixes checkbox and link colors in white theme * [DDW-757] Fixes flat button on white and dark cardano themes, fixes utxo chart on white theme * [DDW-757] Updates white theme with fixes * [DDW-757] Imports correct svg cross icon * [DDW-757] Fixes remaining issues in white theme and also learn more buttons in dark-cardano * [DDW-757] Darkens mnemonics background color in white theme * [DDW-757] White theme CSS fixes * [DDW-757] Add missing stories * [DDW-757] Fixes AdaRedemptionSuccessOverlay styles in white, yellow, and dark-cardano themes * [DDW-757] Fixes AdaRedemptionDisclaimer styles in white, yellow, and dark-cardano themes * [DDW-757] Fixes button colors on trouble syncing/connecting screens in dark-cardano.js * [DDW-757] Fixes Data Layer Migration screen in white, yellow, and dark-cardano themes * [DDW-757] Fixes Data Layer Migration screen in white, yellow, and dark-cardano themes * [DDW-757] Fixes Node Update Notification in yellow theme * [DDW-757] Update storybook stories * [DDW-757] Fixing themes * [DDW-757] Storybook topbar expand icon, loading wallet progress bar color and UTXO charts on white theme * [DDW-757] White theme improvements * [DDW-757] Fixing themes * [DDW-757] White theme final imporvements * [DDW-757] Fixing themes * [DDW-757] Remove testing faked data * [DDW-757] Run prettier * [DDW-757] Fixing themes * [DDW-757] Fixing themes * [DDW-757] Dark Cardano theme UTXO charts improvements * [DDW-757] Failed transactions colors imporovement * [DDW-757] Cardano Dark and White theme improvements * [DDW-757] Eslint warning and prettier fix * [DDW-757] Fix storybook restoration progress * [DDW-757] Different BGs on Overlays * [DDW-757] Syncing screen - tooltip not visible * [DDW-757] Wrong border Staking on Staking screens * [DDW-757] Wrong strip colors on progress bar * [DDW-757] Dropdown triangle arrow on dark theme * [DDW-757] Wrong pop-over colors on Delegation Center * [DDW-757] The final piece of the puzzle * [DDW-757] Adds CHANGELOG entry
…1484) * DDW-776 Fix wrong styling of the Stake Pool in the Dark Blue theme * DDW-776 CHANGELOG * DDW-776 missing border for big pool * [DDW-776] Stake pool thumb colors improvements * [DDW-776] Apply new stake pool thumb colors to selection box
* [DDW-781] Blank Screen Fix - Default Selection. * [DDW-711] Replaces button No by Cancel * [DDW-781] Fixes buttons focus * DDW-781 CHANGELOG
* support haskell.nix builds of cardano * fix icon on `daedalus.exe` * implement HSM client * [DEVOPS-970] re-enable signed uninstallers fix staging cross build * [DDW-775] set cardano revision to 3.0.3 * set target to x86_64-windows in build-cross-windows.sh * add buildNum to release-build and fix suffixes for windows
thedanheller
previously approved these changes
Jul 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🚀
…#1516) * [DDW-815] Removed 'Realtime statistics monitor' link from Testnet builds * [DDW-815] Trigger rebuild
* DDW-812 Fix application dialog close button colour * [DDW-812] CHANGELOG * [DDW-813] Remove unused code * [DDW-812] Run translation manager
…en (#1521) * [DDW-812] Fix notification z-index issue on Daedalus Diagnostics screen * [DDW-812] Prevent display of main UI under the Block consolidation screen
1529: fixes size of linux installer r=disassembler a=disassembler This PR CHANGES. ## Todos - [ ] Todo ## Screenshots - Screenshot --- ## Testing Checklist - [Slack QA thread](https://input-output-rnd.slack.com/messages/GGKFXSKC6) - [ ] Test --- ## Review Checklist ### Basics - [ ] PR has been assigned and has appropriate labels (`feature`/`bug`/`chore`, `release-x.x.x`) - [ ] PR is updated to the most recent version of the target branch (and there are no conflicts) - [ ] PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes - [ ] CHANGELOG entry has been added to the top of the appropriate section (*Features*, *Fixes*, *Chores*) and is linked to the correct PR on GitHub - [ ] Automated tests: All acceptance and unit tests are passing (`yarn test`) - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn dev`) - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn package` / CI builds) - [ ] There are no *flow* errors or warnings (`yarn flow:test`) - [ ] There are no *lint* errors or warnings (`yarn lint`) - [ ] There are no *prettier* errors or warnings (`yarn prettier:check`) - [ ] There are no missing translations (running `yarn manage:translations` produces no changes) - [ ] Text changes are proofread and approved (Jane Wild / Amy Reeve) - [ ] Japanese text changes are proofread and approved (Junko Oda) - [ ] UI changes look good in all themes (Alexander Rukin) - [ ] Storybook works and no stories are broken (`yarn storybook`) - [ ] In case of dependency changes `yarn.lock` file is updated ### Code Quality - [ ] Important parts of the code are properly commented and documented - [ ] Code is properly typed with flow - [ ] React components are split-up enough to avoid unnecessary re-renderings - [ ] Any code that only works in main process is neatly separated from components ### Testing - [ ] New feature/change is covered by acceptance tests - [ ] New feature/change is manually tested and approved by QA team - [ ] All existing acceptance tests are still up-to-date - [ ] New feature/change is covered by Daedalus Testing scenario - [ ] All existing Daedalus Testing scenarios are still up-to-date ### After Review - [ ] Merge the PR - [ ] Delete the source branch - [ ] Move the ticket to `done` column on the YouTrack board - [ ] Update Slack QA thread by marking it with a green checkmark Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io>
nikolaglumac
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.14.0
Features
Fixes
Chores
prettier
formatting tool and set up automation for basic maintainance tasks (PR 1335, PR 1347, PR 1352, PR 1375)Webpack 4
build performance (PR 1320)npm
in favour ofyarn
(PR 1399, PR 1402)React-Polymorph
to version 0.8.6 (PR 1396)createTheme
utility function for rapid generation of new themes (PR 1371, PR 1445)themes:check
script for checking missing definitions oncreateTheme
object (PR 1424)themes:update
script for automatically generating color values usingcreateTheme
and writing the updates to all themes (PR 1464)