[DDW-595] Fix lint warnings #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding fixes for es linter
Adding fixes for es linter
… into chore/ddw-595-fix-lint-warnings # Conflicts: # flow/mappers/CSSModule.js.flow
Adding fixes for es linter
Adding fixes for es linter
Adding fixes for es linter
nikolaglumac
suggested changes
Mar 21, 2019
Added |
nikolaglumac
suggested changes
Mar 22, 2019
There was a problem hiding this comment.
Great work @DeeJayElly - I have only left couple of minor comments. Thanks for fixing them!
source/renderer/app/components/wallet/paper-wallet-certificate/PrintDialog.js
Outdated
Show resolved
Hide resolved
source/renderer/app/components/wallet/paper-wallet-certificate/SecuringPasswordDialog.js
Outdated
Show resolved
Hide resolved
…lint-warnings # Conflicts: # source/main/config.js # source/main/utils/setupLogging.js
| @@ -18,6 +18,7 @@ export const saveScreenshot = async (context, file) => { | |||
| .capturePage() | |||
| .then(imageBuffer => fs.writeFile(file, imageBuffer)) | |||
| .catch(err => { | |||
| // eslint-disable-next-line | |||
There was a problem hiding this comment.
@DeeJayElly please add more details here
nikolaglumac
approved these changes
Mar 25, 2019
24 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors .js codebase with suggested lint fixes so we could clean all components from lint warnings.
Todo:
Review Checklist:
Basics
yarn run test)yarn run dev)yarn run package/ CI builds)yarn run flow:test)yarn run lint)yarn run manage:translationsproduces no changes)yarn run storybook)yarn.lockfile is updatedCode Quality
Testing
After Review:
doneon the Youtrack board