New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-637] Add timestamp for Paper wallet #1385
[DDW-637] Add timestamp for Paper wallet #1385
Conversation
…d-timestamp-for-paper-wallet-pdf-name
…d-timestamp-for-paper-wallet-pdf-name
…' of https://github.com/input-output-hk/daedalus into feature/ddw-637-add-timestamp-for-paper-wallet-pdf-name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…' of https://github.com/input-output-hk/daedalus into feature/ddw-637-add-timestamp-for-paper-wallet-pdf-name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @daniloprates 🎉
This PR implements timestamp on paper wallet PDF filename and content.
TODO
Add timestamp in the PDF content:
MMMM D, YYYY - h:mm A
: May 09, 2019 - 04:30 PMYYYY年M月D日 - HH:mm
: 2019年5月7日 - 16:30Add timestamp in the PDF filename:
YYYY-MM-DDTHHmmss.0SSS
Screenshots
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board