Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-676] Improve network status dialog #1404

Merged
merged 8 commits into from May 27, 2019

Conversation

DeeJayElly
Copy link
Contributor

@DeeJayElly DeeJayElly commented May 23, 2019

This PR CHANGES implementation of statePath variable parsing to Network status dialog. It also removes tooltips on unnecessary fields on Network status dialog and fixes some minor styling issues.

Screenshots

Screenshot 2019-05-23 18 41 45

Wrong text on the last button of the wallet navigation was fixed in the scope of this PR:

Before:
Screen Shot 2019-05-24 at 10 43 12
After:
Screen Shot 2019-05-24 at 10 55 19

Testing Checklist


Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@nikolaglumac nikolaglumac changed the title DDW 676 Improve network status dialog [DDW-676] Improve network status dialog May 24, 2019
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Only one little thing left to be done 🙏

source/common/types/stateDirectory.types.js Outdated Show resolved Hide resolved
source/main/index.js Outdated Show resolved Hide resolved
@IuliaDolishniak IuliaDolishniak self-requested a review May 24, 2019 13:04
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @DeeJayElly 🎉

@nikolaglumac nikolaglumac merged commit ebdb949 into develop May 27, 2019
@iohk-bors iohk-bors bot deleted the chore/ddw-676-improve-network-status-dialog branch May 27, 2019 08:12
@darko-mijic darko-mijic mentioned this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants