Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-685] Stake Pools - Adjustments #1420

Merged
merged 22 commits into from Jun 14, 2019
Merged

[DDW-685] Stake Pools - Adjustments #1420

merged 22 commits into from Jun 14, 2019

Conversation

thedanheller
Copy link
Member

@thedanheller thedanheller commented Jun 10, 2019 •
edited by nikolaglumac

This PR adds fine adjustments to the Stake Pools screen.

Todos

Screenshots

image

Testing Checklist

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@thedanheller thedanheller self-assigned this Jun 10, 2019
@thedanheller thedanheller force-pushed the fix/ddw-685-stake-pools-adjustments branch from a3e1bc6 to d059290 Compare June 10, 2019 22:14
@thedanheller thedanheller removed the WIP label Jun 12, 2019
@thedanheller thedanheller requested a review from a team June 12, 2019 19:40
@DominikGuzei
Copy link
Member

@daniloprates Netlify build is fixed 👍

@thedanheller
Copy link
Member Author

@daniloprates Netlify build is fixed 👍

@DominikGuzei 💛

@alexander-rukin
Copy link
Contributor

image

left distance != right distance (due to the scroll) is this an issue for this PR ?

@alexander-rukin
Copy link
Contributor

image

this bug relates to position, right?

@alexander-rukin
Copy link
Contributor

image

close cross is bigger than 8px should we decrease size?

@alexander-rukin
Copy link
Contributor

image

for controlled stake should be different "color-logic", but this is not issue of this PR, just mentioning

@alexander-rukin
Copy link
Contributor

Rest is very good! 👍

@thedanheller
Copy link
Member Author

this bug relates to position, right?

I'll remove the fixed Search component until we find a better solution. ATM it's taking too much space.

@thedanheller
Copy link
Member Author

left distance != right distance (due to the scroll) is this an issue for this PR ?

@a-rukin in this case, I can't just ignore the right margin, as it would make it even when there's the scrollbar, but uneven when there is not.

Let's leave this one like this and I'll open a card for us to study handling the scrollbar in a better way. Maybe we can apply one of those Javascript solutions globally in the app.

@alexander-rukin
Copy link
Contributor

Let's leave this one like this and I'll open a card for us to study handling the scrollbar in a better way. Maybe we can apply one of those Javascript solutions globally in the app.

Sure 👌

@thedanheller thedanheller removed the WIP label Jun 13, 2019
@thedanheller thedanheller added WIP and removed WIP labels Jun 13, 2019
@thedanheller
Copy link
Member Author

Hey reviewers, all the requests were made and are available here: https://daniloprates.github.io/daedalus/?selectedKind=Staking&selectedStory=Stake%20Pools&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs

nikolaglumac
nikolaglumac suggested changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniloprates great work! I have left you only one very tiny change request: #1420 (comment)

@nikolaglumac
Copy link
Contributor

@MarcusHurney please review this one too 🙏

nikolaglumac
nikolaglumac approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @daniloprates 🎉

@nikolaglumac
Copy link
Contributor

@daniloprates there are some issues with AppVeyor. @cleverca22 will help us resolve them in the scope of this PR.

alexander-rukin
alexander-rukin approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@alexander-rukin alexander-rukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@cleverca22 cleverca22 force-pushed the fix/ddw-685-stake-pools-adjustments branch from 0628a1e to 8b85a1f Compare June 14, 2019 12:26
@thedanheller thedanheller merged commit 567e457 into develop Jun 14, 2019
@iohk-bors iohk-bors bot deleted the fix/ddw-685-stake-pools-adjustments branch June 14, 2019 14:24
@nikolaglumac nikolaglumac mentioned this pull request Jul 15, 2019
Merged
@darko-mijic darko-mijic mentioned this pull request Jul 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolaglumac nikolaglumac nikolaglumac approved these changes

@alexander-rukin alexander-rukin alexander-rukin approved these changes

@IuliaDolishniak IuliaDolishniak IuliaDolishniak approved these changes

@MarcusHurney MarcusHurney Awaiting requested review from MarcusHurney

@tomislavhoracek tomislavhoracek Awaiting requested review from tomislavhoracek

Assignees

@thedanheller thedanheller

Labels
bug release-0.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thedanheller @DominikGuzei @alexander-rukin @nikolaglumac @IuliaDolishniak