Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-696] Update createTheme Definitions #1424

Merged
merged 33 commits into from Jul 11, 2019

Conversation

MarcusHurney
Copy link
Contributor

@MarcusHurney MarcusHurney commented Jun 12, 2019

This PR ensures there are no missing CSS variables between the 3 existing themes in Daedalus and the createTheme utility function.

A new npm script has been added to run this comparison -> themes:check. This script compares cardano.js, dark-blue.js, and light-blue.js to the createTheme object where all theme definitions should exist.

If any variables or keys are missing on the createTheme object, they will be logged to the console in text that matches the theme's primary color on which they exist, but are missing from the createTheme object.

This PR also updates the createTheme object so it isn't missing any definitions. Below is a screenshot showing how the message will look in the instance where definitions were missing (these have been added to createTheme in this PR and are no longer missing).

Screen Shot 2019-07-10 at 1 14 30 AM

Testing Checklist


Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

MarcusHurney and others added 22 commits June 17, 2019 17:14
…ore/ddw-696-update-create-theme-definitions

[DDW-696] Merges develop branch
…eme checks and updates in a Node environment
…ore/ddw-696-update-create-theme-definitions

[DDW-696] Merges develop
…b.com:input-output-hk/daedalus into chore/ddw-696-update-create-theme-definitions

[DDW-696] Merges upstream branch
@MarcusHurney
Copy link
Contributor Author

@nikolaglumac Need an approval here so I can merge into develop, thanks!

@nikolaglumac
Copy link
Contributor

Reviewing this one now...

@nikolaglumac
Copy link
Contributor

No QA needed for this one.

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @MarcusHurney 🎉

@nikolaglumac nikolaglumac merged commit d617f54 into develop Jul 11, 2019
@iohk-bors iohk-bors bot deleted the chore/ddw-696-update-create-theme-definitions branch July 11, 2019 06:42
@darko-mijic darko-mijic mentioned this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants