New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-696] Update createTheme Definitions #1424
Merged
nikolaglumac
merged 33 commits into
develop
from
chore/ddw-696-update-create-theme-definitions
Jul 11, 2019
Merged
[DDW-696] Update createTheme Definitions #1424
nikolaglumac
merged 33 commits into
develop
from
chore/ddw-696-update-create-theme-definitions
Jul 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore/ddw-696-update-create-theme-definitions [DDW-696] Merges develop branch
…and adds coverage for manualUpdate
…ile named updateThemes.js
…eme checks and updates in a Node environment
…t to the themes:check script
…ore/ddw-696-update-create-theme-definitions [DDW-696] Merges develop
…b.com:input-output-hk/daedalus into chore/ddw-696-update-create-theme-definitions [DDW-696] Merges upstream branch
@nikolaglumac Need an approval here so I can merge into |
Reviewing this one now... |
No QA needed for this one. |
nikolaglumac
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @MarcusHurney 🎉
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures there are no missing CSS variables between the 3 existing themes in Daedalus and the
createTheme
utility function.A new npm script has been added to run this comparison ->
themes:check
. This script comparescardano.js
,dark-blue.js
, andlight-blue.js
to thecreateTheme
object where all theme definitions should exist.If any variables or keys are missing on the
createTheme
object, they will be logged to the console in text that matches the theme's primary color on which they exist, but are missing from thecreateTheme
object.This PR also updates the
createTheme
object so it isn't missing any definitions. Below is a screenshot showing how the message will look in the instance where definitions were missing (these have been added tocreateTheme
in this PR and are no longer missing).Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board