Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-635] Shutting down Screen top Priority #1428

Merged
merged 30 commits into from
Jul 10, 2019
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
5a56894
[DDW-635] Shutting down Screen top Priority
DeeJayElly Jun 18, 2019
d9777a3
[DDW-635] Shutting down Screen top Priority
DeeJayElly Jun 18, 2019
8458f95
[DDW-635] Shutting down Screen top Priority
DeeJayElly Jun 18, 2019
5924b66
Merge branch 'develop' into fix/ddw-635-shutting-down-screen-top-prio…
DeeJayElly Jun 21, 2019
929491d
[DDW-635] Shutting down Screen top Priority
DeeJayElly Jun 21, 2019
24a4bba
[DDW-635] Shutting down Screen top Priority
DeeJayElly Jun 24, 2019
1cdc553
[DDW-635] Shutting down Screen top Priority
DeeJayElly Jun 24, 2019
d1aa209
[DDW-635] Shutting down Screen top Priority
DeeJayElly Jun 25, 2019
50168c6
Merge branch 'develop' into fix/ddw-635-shutting-down-screen-top-prio…
DeeJayElly Jun 25, 2019
3b39d5e
[DDW-635] Shutting down Screen top Priority
DeeJayElly Jun 26, 2019
4caff40
Merge branch 'develop' into fix/ddw-635-shutting-down-screen-top-prio…
DeeJayElly Jun 27, 2019
f320ab3
Merge branch 'develop' into chore/ddw-635-shutting-down-screen-top-pr…
nikolaglumac Jun 27, 2019
18a36a5
Merge branch 'develop' into fix/ddw-635-shutting-down-screen-top-prio…
DeeJayElly Jun 27, 2019
3a054d9
Merge remote-tracking branch 'origin/chore/ddw-635-shutting-down-scre…
DeeJayElly Jun 27, 2019
1f564c5
[DDW-635] Merge in latest develop and fix conflict
nikolaglumac Jun 28, 2019
0132067
Merge branch 'develop' into fix/ddw-635-shutting-down-screen-top-prio…
DeeJayElly Jul 1, 2019
c5a9946
Merge remote-tracking branch 'origin/chore/ddw-635-shutting-down-scre…
DeeJayElly Jul 1, 2019
53d1ec6
Merge branch 'develop' into fix/ddw-635-shutting-down-screen-top-prio…
DeeJayElly Jul 5, 2019
afef110
[DDW-635] Shutting down Screen top Priority - fixes
DeeJayElly Jul 5, 2019
0ac2b07
Merge branch 'develop' into fix/ddw-635-shutting-down-screen-top-prio…
DeeJayElly Jul 5, 2019
f0e7653
[DDW-635] Shutting down Screen top Priority - fixes
DeeJayElly Jul 5, 2019
34b5483
[DDW-635] Shutting down Screen top Priority - fixes
DeeJayElly Jul 8, 2019
756a428
Merge branch 'develop' into fix/ddw-635-shutting-down-screen-top-prio…
DeeJayElly Jul 9, 2019
b6ebb22
Merge branch 'develop' into fix/ddw-635-shutting-down-screen-top-prio…
DeeJayElly Jul 10, 2019
f3c6a0c
[DDW-635] Shutting down Screen top Priority - fixes
DeeJayElly Jul 10, 2019
efbdc31
[DDW-635] Shutting down Screen top Priority - fixes
DeeJayElly Jul 10, 2019
74473aa
[DDW-635] Shutting down Screen top Priority - fixes
DeeJayElly Jul 10, 2019
bcc1cd7
[DDW-635] Merge latest develop
nikolaglumac Jul 10, 2019
3d0c9dc
[DDW-635] Minor cleanup
nikolaglumac Jul 10, 2019
35a2220
Merge branch 'develop' into chore/ddw-635-shutting-down-screen-top-pr…
nikolaglumac Jul 10, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Changelog

### Fixes

- Fixed shutting down screen top priority ([PR 1428](https://github.com/input-output-hk/daedalus/pull/1428))
- Added fine adjustments to the Stake Pools screen. ([PR 1420](https://github.com/input-output-hk/daedalus/pull/1420))
- Fixed the Block consolidation status screen not fully shown in minimized mode when the Japanese language is selected ([PR 1416](https://github.com/input-output-hk/daedalus/pull/1416))
- Fixed "marked" dependency vulnerability warning ([PR 1414](https://github.com/input-output-hk/daedalus/pull/1414)
Expand Down
9 changes: 6 additions & 3 deletions source/renderer/app/containers/Root.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default class Root extends Component<Props> {
app,
staking,
} = stores;
const { isActiveDialog } = app;
const { isActiveDialog, _closeActiveDialog } = app;
const { isStakingPage } = staking;
const { isProfilePage, isSettingsPage } = profile;
const { isAdaRedemptionPage } = adaRedemption;
Expand All @@ -47,7 +47,7 @@ export default class Root extends Component<Props> {

// Just render any page that doesn't require wallets to be loaded or node to be connected
if (
(isPageThatDoesntNeedWallets && !isNodeInStoppingSequence) ||
(isPageThatDoesntNeedWallets && !isNodeInStoppingSequence && isSynced) ||
(isProfilePage && (isNotEnoughDiskSpace || !isNodeInStoppingSequence))
) {
return React.Children.only(children);
Expand All @@ -57,8 +57,11 @@ export default class Root extends Component<Props> {
!isSynced ||
!hasLoadedWallets ||
!isSystemTimeCorrect ||
isNotEnoughDiskSpace
isNotEnoughDiskSpace ||
(isNodeInStoppingSequence &&
!isActiveDialog(DIALOGS.DAEDALUS_DIAGNOSTICS))
) {
_closeActiveDialog();
return <LoadingPage stores={stores} actions={actions} />;
}

Expand Down