New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-635] Shutting down Screen top Priority #1428
[DDW-635] Shutting down Screen top Priority #1428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeeJayElly Hello! The About/Diagnostics/Consolidation screens can not be opened while Syncing phase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeeJayElly Diagnostic Screen is also closed after Starting shutting down process. "Only exception is Daedalus Diagnostics screen" rule is not working.
@daniloprates Can you assist here? We need to clarify if these screen should be able to be opened or not at all during the Syncing process? |
…rity # Conflicts: # CHANGELOG.md
Fixed |
Fixed |
Reviewing this one now... |
…en-top-priority' into fix/ddw-635-shutting-down-screen-top-priority
…en-top-priority' into fix/ddw-635-shutting-down-screen-top-priority
…rity # Conflicts: # CHANGELOG.md
…rity # Conflicts: # CHANGELOG.md
Reverted the thing with Block Consolidation background transparency, and fixed the logic with a quick fix. I think its ok we stick with this for now and maybe later we can refactor it when we have more time. Hope you agree on this one @nikolaglumac |
…rity # Conflicts: # CHANGELOG.md
@DeeJayElly I will take over this task. |
This PR CHANGES shutting down screen priority and puts it on top of other screens when the shutdown sequence is started. Shut down screen should be presented while all other screens (if they were open previously) should be closed down.
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board