Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-635] Shutting down Screen top Priority #1428

Merged
merged 30 commits into from Jul 10, 2019

Conversation

DeeJayElly
Copy link
Contributor

@DeeJayElly DeeJayElly commented Jun 18, 2019

This PR CHANGES shutting down screen priority and puts it on top of other screens when the shutdown sequence is started. Shut down screen should be presented while all other screens (if they were open previously) should be closed down.


Testing Checklist

  • Slack QA thread
  • Test if shut down screen is presented when the shutdown sequence is started (Loading screen)
  • Test if shut down screen is presented when shut down sequence is started (Loading screen), and About, Block Consolidation, Daedalus Diagnostics or Ada Redemption screens were previously open.

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@DeeJayElly DeeJayElly self-assigned this Jun 18, 2019
@DeeJayElly DeeJayElly requested a review from a team June 18, 2019 19:47
@DeeJayElly DeeJayElly added bug and removed chore labels Jun 18, 2019
Copy link

@DmitriiGaico DmitriiGaico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly Hello! The About/Diagnostics/Consolidation screens can not be opened while Syncing phase.

Copy link

@DmitriiGaico DmitriiGaico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly Diagnostic Screen is also closed after Starting shutting down process. "Only exception is Daedalus Diagnostics screen" rule is not working.

@DeeJayElly
Copy link
Contributor Author

@DeeJayElly Hello! The About/Diagnostics/Consolidation screens can not be opened while Syncing phase.

@daniloprates Can you assist here? We need to clarify if these screen should be able to be opened or not at all during the Syncing process?

@DeeJayElly
Copy link
Contributor Author

@DeeJayElly Diagnostic Screen is also closed after Starting shutting down process. "Only exception is Daedalus Diagnostics screen" rule is not working.

Fixed

@DeeJayElly
Copy link
Contributor Author

@DeeJayElly Hello! The About/Diagnostics/Consolidation screens can not be opened while Syncing phase.

Fixed

@DeeJayElly DeeJayElly added the WIP label Jun 24, 2019
@DeeJayElly DeeJayElly removed the WIP label Jun 25, 2019
@nikolaglumac nikolaglumac self-requested a review June 27, 2019 09:31
@nikolaglumac
Copy link
Contributor

Reviewing this one now...

@DeeJayElly DeeJayElly removed the WIP label Jul 5, 2019
@DeeJayElly
Copy link
Contributor Author

@DeeJayElly as per our call we need to refactor the logic and revert Block consolidation screen background transparency.

Reverted the thing with Block Consolidation background transparency, and fixed the logic with a quick fix. I think its ok we stick with this for now and maybe later we can refactor it when we have more time.

Hope you agree on this one @nikolaglumac

@DeeJayElly DeeJayElly removed the WIP label Jul 10, 2019
@nikolaglumac nikolaglumac self-assigned this Jul 10, 2019
@nikolaglumac
Copy link
Contributor

@DeeJayElly I will take over this task.

@nikolaglumac nikolaglumac removed the WIP label Jul 10, 2019
@gabriela-ponce gabriela-ponce self-requested a review July 10, 2019 14:33
@nikolaglumac nikolaglumac merged commit 301d05a into develop Jul 10, 2019
@iohk-bors iohk-bors bot deleted the chore/ddw-635-shutting-down-screen-top-priority branch July 10, 2019 15:21
@darko-mijic darko-mijic mentioned this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants