Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-776] Fix wrong styling of the Stake Pool in the Dark Blue theme #1484

Merged
merged 5 commits into from Jul 24, 2019
Merged

[DDW-776] Fix wrong styling of the Stake Pool in the Dark Blue theme #1484

merged 5 commits into from Jul 24, 2019

Conversation

thedanheller
Copy link
Member

@thedanheller thedanheller commented Jul 23, 2019 •
edited by tomislavhoracek

This PR fixes the wrong styling of the Stake Pool in the Dark Blue theme.

Screenshots

Example with broken styles

image

Example with improved styles

Screen Shot 2019-07-24 at 16 30 23

Testing Checklist

  • Slack QA thread
  • Test Storybook story under: Staking -> DelegationStepsChooseStakePool
  • Test Storybook story under: Staking -> Stake Pools

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@thedanheller thedanheller self-assigned this Jul 23, 2019
@thedanheller thedanheller requested a review from a team July 23, 2019 18:28
@tomislavhoracek tomislavhoracek self-requested a review July 24, 2019 08:36
tomislavhoracek
tomislavhoracek requested changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniloprates
This update breaks styles on "Stake pools" screen
https://zpl.io/bzqG1k7

Please add additional variables just for stake-pools on dialogs.
Also just border: solid 1px rgba(102, 122, 138, 0.5); should be enough without background color change. Will looks like this

Screen Shot 2019-07-24 at 10 40 24

What you think?

@tomislavhoracek tomislavhoracek self-assigned this Jul 24, 2019
tomislavhoracek
tomislavhoracek approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@thedanheller thedanheller merged commit 5318411 into develop Jul 24, 2019
@iohk-bors iohk-bors bot deleted the fix/ddw-776-fix-wrong-styling-of-the-stake-pool-in-the-dark-blue-theme branch July 24, 2019 14:53
@darko-mijic darko-mijic mentioned this pull request Jul 30, 2019
Merged
thedanheller added a commit that referenced this pull request Jul 30, 2019
@thedanheller
[DDW-776] Fix wrong styling of the Stake Pool in the Dark Blue theme (#…
4ce4874 
…1484)

* DDW-776 Fix wrong styling of the Stake Pool in the Dark Blue theme

* DDW-776 CHANGELOG

* DDW-776 missing border for big pool

* [DDW-776] Stake pool thumb colors improvements

* [DDW-776] Apply new stake pool thumb colors to selection box
thedanheller added a commit that referenced this pull request Jul 30, 2019
@thedanheller
Updates v2-integration branch (#1498)
9bdb6aa 
* [DDW-761] Fix 'To addresses' in the same line (#1476)

* [DDW-761] Fix 'To addresses' in the same line

* [DDW-761] Add 2 'TO' addresses in the Storybook Transactions story

* [DDW-761] Fix address/transaction hover effect

* [DDW-762] Fix broken 'Read the Article' button (#1479)

* [DDW-762] Fix broken 'Read the Article' button

* [DDW-762] CHANGELOG

* [DDW-764] Fix timestamp date format handling (#1482)

* [DDW-757] Implement new themes (#1480)

* [DDW-757] Introduce yellow / white / dark-cardano themes base setup

* [DDW-757] Add new themes to Settings page

* [DDW-757] Run translations manager

* [DDW-757] Add missing config for new themes create/update and theme images

* [DDW-757] Generate css variables for new themes and yellow theme overrides

* [DDW-757] Adjusts buttons colors in all states, and input/select border colors

* [DDW-757] Auto-updates defaultMessages.json

* [DDW-757] Fixes delegation icon in SideBar to use fill/stroke color in CSS vars

* [DDW-757] Fixes delegation-progress icon in SideBar to use fill/stroke color in CSS vars

* [DDW-757] Fixes create paper wallet icon in SideBar to use fill/stroke color in CSS vars

* [DDW-757] Yellow theme fine tuning and storybook menu new themes selection

* [DDW-757] Fix dark cardano theme config and vars creation

* [DDW-757] Introduce Dark-Cardano theme partial varibles override

* [DDW-757] Yellow theme styles improvements

* [DDW-757] Generating new additional variables for all themes

* [DDW-757] Introduce basic layout variables overrides for White theme

* [DDW-757] Small color improvements for BigDialogButtons, StakePool cards and tooltips, delegation dropdowns on Yellow theme

* [DDW-757] Dark-Blue theme border color on stake pool boxes fix

* [DDW-757] Support icon for yellow theme

* [DDW-757] Fix Support icon disappearing

* [DDW-757] Main background color change

* [DDW-757] Yellow theme - about window fixes

* [DDW-757] Stories to get the current theme and dark icon for white theme

* [DDW-757] Yellow theme - about window overlay color

* [DDW-757] Add MINT variations to White theme and settings page translation improvement

* [DDW-757] Adding new theme images for setting page

* [DDW-757] White overrides - WIP

* [DDW-757] Theme buttons better arrangement

* [DDW-757] Finalizing Yellow theme by resolving requested changes

* [DDW-757] Run prettier

* [DDW-757] UTXO graph colors improvement and options list bg color

* [DDW-757] Fix copy notification text color

* [DDW-757] Fix dropdown bg colors

* [DDW-757] Fix support request hover

* [DDW-757] Update dark cardano theme

* [DDW-757] White theme - WIP

* [DDW-757] White theme - Block consolidation done

* [DDW-757] White theme - Paper Wallet

* [DDW-757] White theme - Transactions

* [DDW-757] Matches Block Consolidation screen to mockups in fine detail

* [DDW-757] Imports taller, thinner cross svg for use in About/Block Consolidation screens

* [DDW-757] Replaces hard coded fill value with CSS variable

* [DDW-757] Uses thinner cross in About.js

* [DDW-757] Handles active/pressed button state on Block Consolidation screen

* [DDW-757] Color value adjustments in all theme files

* [DDW-757] Auto update in defaultMessages.json

* [DDW-757] Fixes checkbox and link colors in white theme

* [DDW-757] Fixes flat button on white and dark cardano themes, fixes utxo chart on white theme

* [DDW-757] Updates white theme with fixes

* [DDW-757] Imports correct svg cross icon

* [DDW-757] Fixes remaining issues in white theme and also learn more buttons in dark-cardano

* [DDW-757] Darkens mnemonics background color in white theme

* [DDW-757] White theme CSS fixes

* [DDW-757] Add missing stories

* [DDW-757] Fixes AdaRedemptionSuccessOverlay styles in white, yellow, and dark-cardano themes

* [DDW-757] Fixes AdaRedemptionDisclaimer styles in white, yellow, and dark-cardano themes

* [DDW-757] Fixes button colors on trouble syncing/connecting screens in dark-cardano.js

* [DDW-757] Fixes Data Layer Migration screen in white, yellow, and dark-cardano themes

* [DDW-757] Fixes Data Layer Migration screen in white, yellow, and dark-cardano themes

* [DDW-757] Fixes Node Update Notification in yellow theme

* [DDW-757] Update storybook stories

* [DDW-757] Fixing themes

* [DDW-757] Storybook topbar expand icon, loading wallet progress bar color and UTXO charts on white theme

* [DDW-757] White theme improvements

* [DDW-757] Fixing themes

* [DDW-757] White theme final imporvements

* [DDW-757] Fixing themes

* [DDW-757] Remove testing faked data

* [DDW-757] Run prettier

* [DDW-757] Fixing themes

* [DDW-757] Fixing themes

* [DDW-757] Dark Cardano theme UTXO charts improvements

* [DDW-757] Failed transactions colors imporovement

* [DDW-757] Cardano Dark and White theme improvements

* [DDW-757] Eslint warning and prettier fix

* [DDW-757] Fix storybook restoration progress

* [DDW-757] Different BGs on Overlays

* [DDW-757] Syncing screen - tooltip not visible

* [DDW-757] Wrong border Staking on Staking screens

* [DDW-757] Wrong strip colors on progress bar

* [DDW-757] Dropdown triangle arrow on dark theme

* [DDW-757] Wrong pop-over colors on Delegation Center

* [DDW-757] The final piece of the puzzle

* [DDW-757] Adds CHANGELOG entry

* [DDW-776] Fix wrong styling of the Stake Pool in the Dark Blue theme (#1484)

* DDW-776 Fix wrong styling of the Stake Pool in the Dark Blue theme

* DDW-776 CHANGELOG

* DDW-776 missing border for big pool

* [DDW-776] Stake pool thumb colors improvements

* [DDW-776] Apply new stake pool thumb colors to selection box

* [DDW-777] Implement link to feature requests (#1487)

* [DDW-785] Reverse buttons order (#1489)

* DDW-780 Truncated third Loading Dot. (#1490)

* [DDW-781] Blank Screen Fix - Default Selection. (#1488)

* [DDW-781] Blank Screen Fix - Default Selection.

* [DDW-711] Replaces button No by Cancel

* [DDW-781] Fixes buttons focus

* DDW-781 CHANGELOG

* [DDW-789] Fix focused button of the 'Blank Screen fix' prompt on Windows (#1493)

* [DDW-775] Cardano SL 3.0.3 integration (#1477)

* support haskell.nix builds of cardano

* fix icon on `daedalus.exe`

* implement HSM client

* [DEVOPS-970] re-enable signed uninstallers
fix staging cross build

* [DDW-775] set cardano revision to 3.0.3

* set target to x86_64-windows in build-cross-windows.sh

* add buildNum to release-build and fix suffixes for windows
thedanheller added a commit that referenced this pull request Jul 30, 2019
@thedanheller
[DDW-776] Fix wrong styling of the Stake Pool in the Dark Blue theme (#…
123c24d 
…1484)

* DDW-776 Fix wrong styling of the Stake Pool in the Dark Blue theme

* DDW-776 CHANGELOG

* DDW-776 missing border for big pool

* [DDW-776] Stake pool thumb colors improvements

* [DDW-776] Apply new stake pool thumb colors to selection box
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topseniors topseniors topseniors approved these changes

@tomislavhoracek tomislavhoracek tomislavhoracek approved these changes

@IuliaDolishniak IuliaDolishniak IuliaDolishniak approved these changes

Assignees

@thedanheller thedanheller

@tomislavhoracek tomislavhoracek

Labels
bug release-0.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thedanheller @topseniors @tomislavhoracek @IuliaDolishniak