Merge master into develop branch #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1516) * [DDW-815] Removed 'Realtime statistics monitor' link from Testnet builds * [DDW-815] Trigger rebuild
* DDW-812 Fix application dialog close button colour * [DDW-812] CHANGELOG * [DDW-813] Remove unused code * [DDW-812] Run translation manager
…en (#1521) * [DDW-812] Fix notification z-index issue on Daedalus Diagnostics screen * [DDW-812] Prevent display of main UI under the Block consolidation screen
1529: fixes size of linux installer r=disassembler a=disassembler This PR CHANGES. ## Todos - [ ] Todo ## Screenshots - Screenshot --- ## Testing Checklist - [Slack QA thread](https://input-output-rnd.slack.com/messages/GGKFXSKC6) - [ ] Test --- ## Review Checklist ### Basics - [ ] PR has been assigned and has appropriate labels (`feature`/`bug`/`chore`, `release-x.x.x`) - [ ] PR is updated to the most recent version of the target branch (and there are no conflicts) - [ ] PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes - [ ] CHANGELOG entry has been added to the top of the appropriate section (*Features*, *Fixes*, *Chores*) and is linked to the correct PR on GitHub - [ ] Automated tests: All acceptance and unit tests are passing (`yarn test`) - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn dev`) - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn package` / CI builds) - [ ] There are no *flow* errors or warnings (`yarn flow:test`) - [ ] There are no *lint* errors or warnings (`yarn lint`) - [ ] There are no *prettier* errors or warnings (`yarn prettier:check`) - [ ] There are no missing translations (running `yarn manage:translations` produces no changes) - [ ] Text changes are proofread and approved (Jane Wild / Amy Reeve) - [ ] Japanese text changes are proofread and approved (Junko Oda) - [ ] UI changes look good in all themes (Alexander Rukin) - [ ] Storybook works and no stories are broken (`yarn storybook`) - [ ] In case of dependency changes `yarn.lock` file is updated ### Code Quality - [ ] Important parts of the code are properly commented and documented - [ ] Code is properly typed with flow - [ ] React components are split-up enough to avoid unnecessary re-renderings - [ ] Any code that only works in main process is neatly separated from components ### Testing - [ ] New feature/change is covered by acceptance tests - [ ] New feature/change is manually tested and approved by QA team - [ ] All existing acceptance tests are still up-to-date - [ ] New feature/change is covered by Daedalus Testing scenario - [ ] All existing Daedalus Testing scenarios are still up-to-date ### After Review - [ ] Merge the PR - [ ] Delete the source branch - [ ] Move the ticket to `done` column on the YouTrack board - [ ] Update Slack QA thread by marking it with a green checkmark Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io>
Release/0.14.0
darko-mijic
approved these changes
Aug 14, 2019
tomislavhoracek
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
mastercode intodevelopbranch.