-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-298] Display withdrawals in transaction details #2065
[DDW-298] Display withdrawals in transaction details #2065
Conversation
…have been used for the transaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@daniloprates @tomothespian please review this one 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 very minor comment. apart from that, great stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikolaglumac Amazing 🎉
🎉 |
This PR adds display of withdrawals in transaction details in case rewards have been used for the transaction.
We are also changing Japanese translation for the From addresses as per document: https://docs.google.com/document/d/1njBmB3LceuRB8m7xP08maQ0QK30h4XGiF2BUdAx5OdE/edit
Design: https://zpl.io/blkK46X
IMPORTANT:
"From rewards" section is shown ONLY if rewards have been consumed in transaction!
Screenshots
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board