Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-298] Display withdrawals in transaction details #2065

Merged
merged 7 commits into from
Jul 16, 2020

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Jul 15, 2020

This PR adds display of withdrawals in transaction details in case rewards have been used for the transaction.
We are also changing Japanese translation for the From addresses as per document: https://docs.google.com/document/d/1njBmB3LceuRB8m7xP08maQ0QK30h4XGiF2BUdAx5OdE/edit

Design: https://zpl.io/blkK46X

IMPORTANT:

"From rewards" section is shown ONLY if rewards have been consumed in transaction!

Screenshots

Screenshot 2020-07-15 at 09 33 55

Screenshot 2020-07-15 at 09 34 04


Testing Checklist


Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

Copy link
Contributor

@alexander-rukin alexander-rukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nikolaglumac
Copy link
Contributor Author

@daniloprates @tomothespian please review this one 🙏

Copy link
Contributor

@thedanheller thedanheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 very minor comment. apart from that, great stuff.

Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikolaglumac Amazing 🎉

@darko-mijic
Copy link
Contributor

This is working properly now:

image

@nikolaglumac nikolaglumac merged commit 888cf22 into develop Jul 16, 2020
@iohk-bors iohk-bors bot deleted the feature/ddw-298-display-transaction-withdrawals branch July 16, 2020 07:18
@darko-mijic
Copy link
Contributor

🎉

@nikolaglumac nikolaglumac added the release-1.3.0-STN2 Daedalus Shelley Testnet label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature release-1.3.0-STN2 Daedalus Shelley Testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants