-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-500] Implement native tokens #2292
Merged
nikolaglumac
merged 423 commits into
develop
from
feature/ddw-500-implement-design-for-native-tokens
Feb 27, 2021
Merged
[DDW-500] Implement native tokens #2292
nikolaglumac
merged 423 commits into
develop
from
feature/ddw-500-implement-design-for-native-tokens
Feb 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaglumac
suggested changes
Feb 1, 2021
@DeeJayElly please merge latest develop... |
…e tokens asset add
…e tokens asset add
…e tokens asset add
…e tokens asset add
…-for-native-tokens' into feature/ddw-500-implement-design-for-native-tokens
darko-mijic
approved these changes
Feb 27, 2021
alan-mcnicholas
approved these changes
Feb 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible work as always!
miorsufianiohk
approved these changes
Feb 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . Tested on 16862.
iohk-bors
bot
deleted the
feature/ddw-500-implement-design-for-native-tokens
branch
February 27, 2021 23:18
nikolaglumac
added
release-4.0.0-RC1
Daedalus Testnet
release-4.0.0-FC1
Daedalus Flight
release-4.0.0
Daedalus Mainnet
and removed
⏳release-vNext
labels
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
release-4.0.0-FC1
Daedalus Flight
release-4.0.0-RC1
Daedalus Testnet
release-4.0.0
Daedalus Mainnet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements design for native tokens.
Design:
https://zpl.io/VDeA6BJ - multi-send
https://zpl.io/VxEwEPR - multi-send confirmation dialog
https://zpl.io/bAr9Roe - wallet with tokens
https://zpl.io/2vv8qWe - wallet with tokens - popover
https://zpl.io/VQlz9XP - tx details
Issues
Issue list is in this document
Scenarios
Todos
New ones
Show AssetToken popOver in the Token input [@daniloprates ](Not possible, for now. The hover element needs to be the hidden Dropdown input. If the PopOver hovering element gets on top, the PopOver won't work. We can improve this in the future, but for now it's too risky)NaN
error upon entering typing comma character in Numeric Input [@nikolaglumac ]Tomorrow (Nice to have)
@DeeJayElly
@daniloprates
@nikolaglumac
Pending issues
UI issues document:
https://docs.google.com/document/d/1R5lhnDGMIT6JguzGc0fiYTPDv4QiNTm4hSjMFIyab8w/edit
Screenshots
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board