New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-605] Display rewards address #2475
[DDW-605] Display rewards address #2475
Conversation
…address' into feature/ddw-605-display-rewards-address
…address' into feature/ddw-605-display-rewards-address
Hi @aleksandardjordjeviciohk. Implementation looks good. I just have one question/recommendation. Would it look better if the spinner would be aligned to the left like Wallet and Total rewards earned(ADA) columns when address field is blank. What do you think @nikolaglumac ? In Zepelin it shows the loading spinner next to the address but it seems both dont exist at the same time as address only pops up after its fully loaded Screenshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aleksandardjordjeviciohk please see my change requests 🙏
source/renderer/app/components/staking/rewards/StakingRewardsForIncentivizedTestnet.js
Outdated
Show resolved
Hide resolved
{isRestoring && ( | ||
</td> | ||
<td className={styles.rewardsAddress}> | ||
{isRestoring ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aleksandardjordjeviciohk please make sure we show the rewards address during restoration too.
cc @ManusMcCole
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aleksandardjordjeviciohk please post screenshots once this is fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ManusMcCole @gabriela-ponce @miorsufianiohk @aleksandardjordjeviciohk we want this screen to look like this:
The rewards address column is to be in the middle!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @aleksandardjordjeviciohk 👍
Hi @aleksandardjordjeviciohk. When downloaded to the .csv now the headers are in the right place but the values for Rewards Address and Total Rewards Earned(ADA) are mixed up. See Screenshot |
Fixed @ManusMcCole |
This PR adds a display of wallet rewards address.
Todos
on the "Rewards" screen:
Screenshots
Testing Checklist
Test Cases
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board