[DDW-742] Fix receiver address validation (disallow rewards address) #2781

przemyslaw-wlodek · 2021-12-09T16:46:31Z

This PR fixes receiver address validation by disallowing rewards addresses.

Todos

N/A

Screenshots

Testing Checklist

Slack QA thread
Test

Test Scenarios

Scenario 1: Entering a rewards address will display error message
Given I have a wallet
And I have a staking address
And I am on the Send tab
When I enter the staking address in the wallet Receiver field
Then 'Please enter a valid address' error will be displayed

Scenario 2: Entering a valid address will not display error message
Given I have a wallet
And I have a valid wallet address
And I am on the Send tab
When I enter the valid wallet address in the wallet Receiver field
Then the address is accepted
And no error is displayed

Review Checklist

Basics

Code Quality

Important parts of the code are properly commented and documented
Code is properly typed with flow
React components are split-up enough to avoid unnecessary re-renderings
Any code that only works in main process is neatly separated from components

Testing

New feature/change is covered by acceptance tests
New feature/change is manually tested and approved by QA team
All existing acceptance tests are still up-to-date
New feature/change is covered by Daedalus Testing scenario
All existing Daedalus Testing scenarios are still up-to-date

After Review

Merge the PR
Delete the source branch
Move the ticket to done column on the YouTrack board
Update Slack QA thread by marking it with a green checkmark

…r validation

* Removed RTS Flags from CHANGELOG * Bump version to 4.6.0

…ceiver-address-validation

…ated)

ManusMcCole

Looks good to me 👍

source/renderer/app/utils/hardwareWalletUtils.js

…ceiver-address-validation

renanvalentin

Great job 🎉

miorsufianiohk

LGTM. Great job @przemyslaw-wlodek .Tested on 20142. 👍

danielmain

Great job @przemyslaw-wlodek

Do you know why yarn.lock was updated?

This reverts commit 0a8769a.

As discovered we had some packages without fixed version that we had yarn.lock changes

…2781)

@lucas-barros

* Added jest and couple of unit tests for DDW-706 * Applied code review suggestions * Fixed wrong dependencies * Added a new test and a default config file * unicode-property pump * [DDW-706] Move new jest specs into tests folder * [DDW-706] Add Github action workflow for jest tests * Fix build issues * [DDW-706] Use supported node version in Github actions * [DDW-706] fix github action node version * Fix yarn.lock * Fix CI issues * Fix CI issues * downgrade to jest 26 * fix lockfile * Testing adding the conflict dependency as primary * Downgrade of istanbul-lib-report * [DDW-735] Merge and gix conflicts * [DDW-735] Merge and fix conflicts * [DDW-779] Update trezor-connect to the latest version 8.2.2-rc.1-multisig * [DDW-779] Add util-deprecate to yarn2nix * [DDW-815] Fix broken Ledger support on Linux (#2741) * fix yarn dev on linux * fix ledger on linux * [DDW-815] Adds CHANGELOG entery * fix windows builds * remove LD_PRELOAD to make the code more stable Co-authored-by: Nikola Glumac <niglumac@gmail.com> * Fix wallet restore dialog and continue disable check (#2745) * Fix walleFix wallet restore dialog and continue disable check * Updated CHANGELOG Co-authored-by: Nikola Glumac <niglumac@gmail.com> * Updated CHANGELOG.md * Change istanbul-lib-report resolution to 3.0.0 * Revert "Change istanbul-lib-report resolution to 3.0.0" This reverts commit 9f63133. * Reverted bump * Reverted bump * [DDW-779] Update trezor-connect to the 8.2.3-beta.3 version * [DDW-779] Remove hd-wallet from yarn2nix * [DDW-779] Update yarn.lock * [DDW-779] Remove hw-wallet from MacInstaller * [DDW-779] Remove merkle-lib from MacInstaller * [DDW-779] Remove multiple sub-dependencies from MacInstaller * [DDW-779] Remove secp256k1 from yarn2nix * [DDW-779] Replace secp256k1 with tiny-secp256k1 in yarn2nix * Merges release/4.5.1 into release/4.5.0 * Fixes CHANGELOG link * [DDW-779] Remove tiny-secp256k1 from yarn2nix * [DDW-779] Add bech32 to yarn2nix * [DDW-779] Add blake-hash to yarn2nix * [DDW-779] Add blake-hash to MacInstaller * [DDW-779] Add tiny-secp256k1 to MacInstaller * [DDW-779] Add bn.js to MacInstaller * [DDW-779] Add elliptic to MacInstaller * [DDW-779] Add minimalistic-assert to MacInstaller * [DDW-779] Add minimalistic-crypto-utils to MacInstaller * [DDW-779] Add minimalistic-crypto-utils to MacInstaller * [DDW-779] Add brorand to MacInstaller * [DDW-779] Add hash.js and hmac-drbg to MacInstaller * [DDW-779] Add int64-buffer to MacInstaller * [DDW-771] Add apache license to npm package * [DDW-771] Remove apache license from package.json again * [DDW-771] refactor to multi-line template literals * [DDW-811] Normalize checkbox tick offset * [DDW-824] Introduce a fix for app update on specific platform * [DDW-824] Improve faked data loading * [DDW-824] CHANGELOG update * [DDW-824] Remove unnecessary comment * fix linux build * [DDW-847] Bump CWB to v2021-11-11 * [DDW-847] CHANGELOG update * [DDW-683] Adjusted slider onAfterChange * [DDW-683] Updated CHANGELOG * [DDW-683] Converted component from class to functional * Removed unstable rts flags * [DDW-824] Restrict FAKED news QA loader to DEV mode only * [DDW-785] Discreet mode - Create the Discreet Mode variables * [DDW-738] Setup feature-driven design Co-authored-by: Lucas <lukas_barros@hotmail.com> Co-authored-by: Dominik Guzei <dominik.guzei@gmail.com> * [DDW-813] Move discreet mode behavior to its own feature * [DDW-738] Fix circular dependency * [DDW-786] Discreet mode - Create the TopBar icon (#2725) * [DDW-786] Added discreet mode toggle component * [DDW-789] Remove specific styles from component * [DDW-789] Fix translations * [DDW-789] CHANGELOG * [DDW-789] Fix eslint issue * [DDW-789] Remove popover theme variables * [DDW-789] Increase height for hide icon * [DDW-789] Remove style * [DDW-789] Rearrange icons to group by action or info * [DDW-786] Add japanese translations * [DDW-786] Rearrange icons order * [DDW-786] Add opacity * [DDW-786] Add isDiscreetMode control to story * [DDW-786] Fix gap width * [DDW-786] Fix default message * [DDW-786] Update to use mobx feature pattern * [DDW-786] Fix style * [DDW-738] Move toggle component to discreet mode feature folder * [DDW-738] Update translations file * [DDW-738] Remove popOver from DiscreetToggle * [DDW-814] Discreet mode - hide sensitive information (#2742) * [DDW-814] Fix React Dev Tools installation * [DDW-814] Hide sensitive values * [DDW-814] Setup storybook * [DDW-814] Localstorage factory * [DDW-814] Hide token amount for decimal config * [DDW-814] Refactor discreet mode ui components * [DDW-814] Directly use discreet mode feature in toggle * [DDW-814] Introduce configurable replacer pattern * [DDW-814] Create LocalStorageFeatureProvider * [DDW-814] Fix flow * [DDW-814] Fix topbar * [DDW-814] React to state changes on WalletUTXO description * [DDW-814] Preseve Stake pools ranking slider value * [DDW-814] Hide filter input * [DDW-814] Prevent stake pools from refreshing * [DDW-814] Update README * [DDW-814] Hide wallets dropdown in discreet mode * [DDW-814] Disable All transactions button on Filter dialog * [DDW-814] Rename DiscreetToggle component * [DDW-814] Add unit tests for discreet replacers * [DDW-814] Cleanup minor issues * [DDW-814] Fix prettier * [DDW-814] Revert istanbul * [DDW-814] Fix flow errors * [DDW-814] Add discreet toggle mode knob Co-authored-by: Dominik Guzei <dominik.guzei@gmail.com> * [DDW-787] Discreet mode - Implement the Settings option (#2740) * [DDW-785] Discreet mode - Create the Discreet Mode variables * [DDW-786] Discreet mode - Create the TopBar icon (#2725) * [DDW-786] Added discreet mode toggle component * [DDW-789] Remove specific styles from component * [DDW-789] Fix translations * [DDW-789] CHANGELOG * [DDW-789] Fix eslint issue * [DDW-789] Remove popover theme variables * [DDW-789] Increase height for hide icon * [DDW-789] Remove style * [DDW-789] Rearrange icons to group by action or info * [DDW-786] Add japanese translations * [DDW-786] Rearrange icons order * [DDW-786] Add opacity * [DDW-786] Add isDiscreetMode control to story * [DDW-786] Fix gap width * [DDW-786] Fix default message * [DDW-786] Update to use mobx feature pattern * [DDW-786] Fix style * [DDW-787] Implement discreet mode settings * [DDW-787] Fix text * [DDW-787] Add story * [DDW-787] Update translations * [DDW-787] Update translations * [DDW-787] Discreet mode tooltip local storage setting * [DDW-787] NotificationPopOver component * [DDW-787] Migrate Sidebar to functional component * [DDW-787] Wrap categories with NotificationPopOver * [DDW-787] Fix lint * [DDW-787] Add new placements * [DDW-787] Add default translations * [DDW-787] Adjust styles * [DDW-787] One time fixed popOver * [DDW-787] Add red dot to discreet mode settings * [DDW-787] Update initial translations * [DDW-787] Add styles specific for language * [DDW-787] Update action text * [DDW-787] Review changes * [DDW-787] Update translations * [DDW-787] Changelog * [DDW-787] Fix tooltip showing after accessing security tab * [DDW-787] Fix notification dot click * [DDW-787] Fix jumping icons * [DDW-787] Add jp translation * [DDW-787] Fix styling issues * [DDW-787] Remove red dot when user leaves security tab * [DDW-787] Fix tooltip overlap * [DDW-787] Fix click through tooltip * [DDW-787] Fix tooltip overlap dialogs * [DDW-787] Fix prettier issue * [DDW-787] Dismiss tooltip on route leave * [DDW-787] Fix tooltip overlaping issues * [DDW-787] Fix closing discreet mode popover on staking page * [DDW-787] Fix merge conflicts * [DDW-787] Move condition to const * [DDW-787] Move trigger component to stand alone hook * [DDW-787] Fix type import * [DDW-787] Remove unused * [DDW-787] Review changes Co-authored-by: Renan Ferreira <renan.ferreira@iohk.io> * [DDW-738] Notification knob * [DDW-839] Discreet mode - automated tests (#2756) * [DDW-839] Discreet mode integration tests * [DDW-839] Remove aria-query from yarnlock * [DDW-839] Remove istanbul from yarnlock * [DDW-839] Tests for public api * [DDW-839] Run lockfile:fix * [DDW-839] Update changelog * [DDW-738] Fix font weights * [DDW-738] Fix button style * [DDW-738] Fix button style * [DDW-738] Pin package version * [DDW-738] Fix name/icon overlapping * [DDW-738] Update yarn.lock * [DDW-738] Review changes * [DDW-738] Fix yarn.lock * [DDW-738] Review changes * [DDW-738] Review changes - use lang selector * [DDW-738] Fix flow issue * [DDW-738] Fix discreet mode logic on filter component * [DDW-854] Init * [DDW-854] New line * [DDW-854] Adjustments * [DDW-854] Update copy * [DDW-854] Small fix * [DDW-854] Small adjustment * [DDW-854] Update icon size * [DDW-854] Fix sass lint * [DDW-854] Update description color * [DDW-854] Update changelog * [DDW-854] Update changelog * [DDW-854] Update message for verifyng stage * [DDW-854] Update colors * [DDW-796] Refactor and voting phases * [DDW-796] Remove closed voting logic * [DDW-796] Exclude js/ts files from nix-build glob * [DDW-796] Fund phase logic * [DDW-796] Fund phase components * [DDW-796] Fix lint issues * [DDW-796] Fix flow issues * [DDW-796] Style fix * [DDW-796] Add observer * [DDW-796] Remove unused * [DDW-796] Lazy validation * [DDW-796] Update text * [DDW-858] Fix eslint warnings * [DDW-796] Add jp translations * [DDW-796] Enable voting in all env for testing only * [DDW-796] Add function for external link * [DDW-796] Review changes * [DDW-796] VotingStore unit test * [DDW-796] Update story * [DDW-796] Test only * Revert "[DDW-796] Test only" This reverts commit 3140b65. * Revert "[DDW-796] Enable voting in all env for testing only" This reverts commit 454c7e1. * [DDW-779] Update trezor connect to the official 8.2.3-extended version * [DDW-779] Remove bigi from MacInstaller * [DDW-779] Remove bigi from MacInstaller * [DDW-779] Remove bigi from MacInstaller * [DDW-779] Remove bytebuffer-old-fixed-webpack from MacInstaller * [DDW-779] Add babel-runtime 7.12.5 to yarn.lock * [DDW-854] Remove opacity property * [DDW-779] Rebuild yarn.lock * [DDW-779] Add protobufjs and bytebuffer to MacInstaller * [DDW-854] Added flow return type * [DDW-779] Update trezor-connect to 8.2.3-beta.8 version * Fixed duplicated text, wrong order * Bump version to 4.6.0 (#2780) * Removed RTS Flags from CHANGELOG * Bump version to 4.6.0 * [DDW-779] Update trezor-connect to v.8.2.4-extended and fix MacInstaller/yarn2nix * [DDW-779] Remove protobufjs from MacInstaller/yarn2nix * [DDW-779] Add @protobufjs * [DDW-779] CHANGELOG update * [DDW-821] Update packages with vulnerabilities (#2769) * [DDW-821] Upgrade packages with vulnerabilities * [DDW-821] Update node headers SHA checksum * [DDW-821] Update CHANGELOG.md * [DDW-821] Upgrade packages with vulnerabilities * [DDW-821] Update node headers SHA checksum * [DDW-821] Update CHANGELOG.md * [DDW-821] Downgrade electron-rebuild * Revert "[DDW-821] Downgrade electron-rebuild" This reverts commit ce4eabb. * Run lockfile:fix * Revert "Revert "[DDW-821] Downgrade electron-rebuild"" This reverts commit debe1c3. * [DDW-821] upgrate low severity vulnerabilities * [DDW-821] align babel config for private methods, class properties and object properties * [DDW-821] Remove explicit resolve-url installation * [DDW-821] Replace deprecated babel-eslint with @babel/eslint-parser * [DDW-821] Fix eslint error by wrapping util script in IIFE * [DDW-821] Fix yarn.lock Co-authored-by: Michael Chappell <michael.chappell@iohk.io> Co-authored-by: Tomislav Horaček <tomislav@tt-media.hr> * [DDW-874] Update README with nix.conf for Apple M1 (only for development purposes) (#2792) * [DDW-874] Update README with nix.conf for Apple M1 * [DDW-874] Update README - simplify nix.conf for M1 chip * [DDW-874] Update README nix.conf Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * [DDW-742] Fix receiver address validation (disallow rewards address) (#2781) * [DDW-882] Update cardano-wallet and cardano-node (#2799) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * [DDW-857][DEBT] Integrate Chromatic (#2776) * [DDW-893] Update the PR checklist (#2811) * [DDW-892] Use fresh locale while rebuilding the application menu (#2813) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * Update develop with release 4.7.0 (#2819) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> Co-authored-by: Lucas <lucas.araujo@iohk.io> Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io> * [DDW-891] update cardano-node to 1.33.0 (#2822) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * [DDW-916] Change the message for syncing the blockchain (#2827) * [DDW-916] Update second message on the initial screen to in include part regarding the waiting time (#2831) * [DDW-862] Enable dynamic RTS flags setting (#2758) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Marcin Mazurek <marcin.mazurek@iohk.io> * Bump version to 4.8.0 * [DDW-918] Update blockchain verification progress (#2840) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> Co-authored-by: Szymon Masłowski <szymon.maslowski@iohk.io> * [DDW-920] RTS flags UI/UX improvements (#2842) Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * [DDW-867] Check disk space (release ver) (#2845) Work originally done by @lucas-barros all credits to him * [DDW-920] Reduce the RAM threshold for RTS mode recommendation (#2846) * [DDW-920] Missing Japanese translations for RTS flags (#2848) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> Co-authored-by: Dominik Guzei <dominik.guzei@gmail.com> Co-authored-by: Nikola Glumac <niglumac@gmail.com> Co-authored-by: Tomislav Horaček <tomislav@tt-media.hr> Co-authored-by: Michael Bishop <michael.bishop@iohk.io> Co-authored-by: Daniel Main <daniel.main.cernhoff@icould.com> Co-authored-by: Renan Ferreira <renan.ferreira@iohk.io> Co-authored-by: Lucas <lukas_barros@hotmail.com> Co-authored-by: Lucas Araujo <lucas.araujo@iohk.io> Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Przemysław Włodek <przem.wlodek.github@gmail.com> Co-authored-by: Marcin Mazurek <marcin@mazurek.pro> Co-authored-by: Szymon Masłowski <i.am.szymon.maslowski@gmail.com> Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io> Co-authored-by: Szymon Masłowski <szymon.maslowski@iohk.io> Co-authored-by: Marcin Mazurek <marcin.mazurek@iohk.io>

@lucas-barros

* Added jest and couple of unit tests for DDW-706 * Applied code review suggestions * Fixed wrong dependencies * Added a new test and a default config file * unicode-property pump * [DDW-706] Move new jest specs into tests folder * [DDW-706] Add Github action workflow for jest tests * Fix build issues * [DDW-706] Use supported node version in Github actions * [DDW-706] fix github action node version * Fix yarn.lock * Fix CI issues * Fix CI issues * downgrade to jest 26 * fix lockfile * Testing adding the conflict dependency as primary * Downgrade of istanbul-lib-report * [DDW-735] Merge and gix conflicts * [DDW-735] Merge and fix conflicts * [DDW-779] Update trezor-connect to the latest version 8.2.2-rc.1-multisig * [DDW-779] Add util-deprecate to yarn2nix * [DDW-815] Fix broken Ledger support on Linux (#2741) * fix yarn dev on linux * fix ledger on linux * [DDW-815] Adds CHANGELOG entery * fix windows builds * remove LD_PRELOAD to make the code more stable Co-authored-by: Nikola Glumac <niglumac@gmail.com> * Fix wallet restore dialog and continue disable check (#2745) * Fix walleFix wallet restore dialog and continue disable check * Updated CHANGELOG Co-authored-by: Nikola Glumac <niglumac@gmail.com> * Updated CHANGELOG.md * Change istanbul-lib-report resolution to 3.0.0 * Revert "Change istanbul-lib-report resolution to 3.0.0" This reverts commit 9f63133. * Reverted bump * Reverted bump * [DDW-779] Update trezor-connect to the 8.2.3-beta.3 version * [DDW-779] Remove hd-wallet from yarn2nix * [DDW-779] Update yarn.lock * [DDW-779] Remove hw-wallet from MacInstaller * [DDW-779] Remove merkle-lib from MacInstaller * [DDW-779] Remove multiple sub-dependencies from MacInstaller * [DDW-779] Remove secp256k1 from yarn2nix * [DDW-779] Replace secp256k1 with tiny-secp256k1 in yarn2nix * Merges release/4.5.1 into release/4.5.0 * Fixes CHANGELOG link * [DDW-779] Remove tiny-secp256k1 from yarn2nix * [DDW-779] Add bech32 to yarn2nix * [DDW-779] Add blake-hash to yarn2nix * [DDW-779] Add blake-hash to MacInstaller * [DDW-779] Add tiny-secp256k1 to MacInstaller * [DDW-779] Add bn.js to MacInstaller * [DDW-779] Add elliptic to MacInstaller * [DDW-779] Add minimalistic-assert to MacInstaller * [DDW-779] Add minimalistic-crypto-utils to MacInstaller * [DDW-779] Add minimalistic-crypto-utils to MacInstaller * [DDW-779] Add brorand to MacInstaller * [DDW-779] Add hash.js and hmac-drbg to MacInstaller * [DDW-779] Add int64-buffer to MacInstaller * [DDW-771] Add apache license to npm package * [DDW-771] Remove apache license from package.json again * [DDW-771] refactor to multi-line template literals * [DDW-811] Normalize checkbox tick offset * [DDW-824] Introduce a fix for app update on specific platform * [DDW-824] Improve faked data loading * [DDW-824] CHANGELOG update * [DDW-824] Remove unnecessary comment * fix linux build * [DDW-847] Bump CWB to v2021-11-11 * [DDW-847] CHANGELOG update * [DDW-683] Adjusted slider onAfterChange * [DDW-683] Updated CHANGELOG * [DDW-683] Converted component from class to functional * Removed unstable rts flags * [DDW-824] Restrict FAKED news QA loader to DEV mode only * [DDW-785] Discreet mode - Create the Discreet Mode variables * [DDW-738] Setup feature-driven design Co-authored-by: Lucas <lukas_barros@hotmail.com> Co-authored-by: Dominik Guzei <dominik.guzei@gmail.com> * [DDW-813] Move discreet mode behavior to its own feature * [DDW-738] Fix circular dependency * [DDW-786] Discreet mode - Create the TopBar icon (#2725) * [DDW-786] Added discreet mode toggle component * [DDW-789] Remove specific styles from component * [DDW-789] Fix translations * [DDW-789] CHANGELOG * [DDW-789] Fix eslint issue * [DDW-789] Remove popover theme variables * [DDW-789] Increase height for hide icon * [DDW-789] Remove style * [DDW-789] Rearrange icons to group by action or info * [DDW-786] Add japanese translations * [DDW-786] Rearrange icons order * [DDW-786] Add opacity * [DDW-786] Add isDiscreetMode control to story * [DDW-786] Fix gap width * [DDW-786] Fix default message * [DDW-786] Update to use mobx feature pattern * [DDW-786] Fix style * [DDW-738] Move toggle component to discreet mode feature folder * [DDW-738] Update translations file * [DDW-738] Remove popOver from DiscreetToggle * [DDW-814] Discreet mode - hide sensitive information (#2742) * [DDW-814] Fix React Dev Tools installation * [DDW-814] Hide sensitive values * [DDW-814] Setup storybook * [DDW-814] Localstorage factory * [DDW-814] Hide token amount for decimal config * [DDW-814] Refactor discreet mode ui components * [DDW-814] Directly use discreet mode feature in toggle * [DDW-814] Introduce configurable replacer pattern * [DDW-814] Create LocalStorageFeatureProvider * [DDW-814] Fix flow * [DDW-814] Fix topbar * [DDW-814] React to state changes on WalletUTXO description * [DDW-814] Preseve Stake pools ranking slider value * [DDW-814] Hide filter input * [DDW-814] Prevent stake pools from refreshing * [DDW-814] Update README * [DDW-814] Hide wallets dropdown in discreet mode * [DDW-814] Disable All transactions button on Filter dialog * [DDW-814] Rename DiscreetToggle component * [DDW-814] Add unit tests for discreet replacers * [DDW-814] Cleanup minor issues * [DDW-814] Fix prettier * [DDW-814] Revert istanbul * [DDW-814] Fix flow errors * [DDW-814] Add discreet toggle mode knob Co-authored-by: Dominik Guzei <dominik.guzei@gmail.com> * [DDW-787] Discreet mode - Implement the Settings option (#2740) * [DDW-785] Discreet mode - Create the Discreet Mode variables * [DDW-786] Discreet mode - Create the TopBar icon (#2725) * [DDW-786] Added discreet mode toggle component * [DDW-789] Remove specific styles from component * [DDW-789] Fix translations * [DDW-789] CHANGELOG * [DDW-789] Fix eslint issue * [DDW-789] Remove popover theme variables * [DDW-789] Increase height for hide icon * [DDW-789] Remove style * [DDW-789] Rearrange icons to group by action or info * [DDW-786] Add japanese translations * [DDW-786] Rearrange icons order * [DDW-786] Add opacity * [DDW-786] Add isDiscreetMode control to story * [DDW-786] Fix gap width * [DDW-786] Fix default message * [DDW-786] Update to use mobx feature pattern * [DDW-786] Fix style * [DDW-787] Implement discreet mode settings * [DDW-787] Fix text * [DDW-787] Add story * [DDW-787] Update translations * [DDW-787] Update translations * [DDW-787] Discreet mode tooltip local storage setting * [DDW-787] NotificationPopOver component * [DDW-787] Migrate Sidebar to functional component * [DDW-787] Wrap categories with NotificationPopOver * [DDW-787] Fix lint * [DDW-787] Add new placements * [DDW-787] Add default translations * [DDW-787] Adjust styles * [DDW-787] One time fixed popOver * [DDW-787] Add red dot to discreet mode settings * [DDW-787] Update initial translations * [DDW-787] Add styles specific for language * [DDW-787] Update action text * [DDW-787] Review changes * [DDW-787] Update translations * [DDW-787] Changelog * [DDW-787] Fix tooltip showing after accessing security tab * [DDW-787] Fix notification dot click * [DDW-787] Fix jumping icons * [DDW-787] Add jp translation * [DDW-787] Fix styling issues * [DDW-787] Remove red dot when user leaves security tab * [DDW-787] Fix tooltip overlap * [DDW-787] Fix click through tooltip * [DDW-787] Fix tooltip overlap dialogs * [DDW-787] Fix prettier issue * [DDW-787] Dismiss tooltip on route leave * [DDW-787] Fix tooltip overlaping issues * [DDW-787] Fix closing discreet mode popover on staking page * [DDW-787] Fix merge conflicts * [DDW-787] Move condition to const * [DDW-787] Move trigger component to stand alone hook * [DDW-787] Fix type import * [DDW-787] Remove unused * [DDW-787] Review changes Co-authored-by: Renan Ferreira <renan.ferreira@iohk.io> * [DDW-738] Notification knob * [DDW-839] Discreet mode - automated tests (#2756) * [DDW-839] Discreet mode integration tests * [DDW-839] Remove aria-query from yarnlock * [DDW-839] Remove istanbul from yarnlock * [DDW-839] Tests for public api * [DDW-839] Run lockfile:fix * [DDW-839] Update changelog * [DDW-738] Fix font weights * [DDW-738] Fix button style * [DDW-738] Fix button style * [DDW-738] Pin package version * [DDW-738] Fix name/icon overlapping * [DDW-738] Update yarn.lock * [DDW-738] Review changes * [DDW-738] Fix yarn.lock * [DDW-738] Review changes * [DDW-738] Review changes - use lang selector * [DDW-738] Fix flow issue * [DDW-738] Fix discreet mode logic on filter component * [DDW-854] Init * [DDW-854] New line * [DDW-854] Adjustments * [DDW-854] Update copy * [DDW-854] Small fix * [DDW-854] Small adjustment * [DDW-854] Update icon size * [DDW-854] Fix sass lint * [DDW-854] Update description color * [DDW-854] Update changelog * [DDW-854] Update changelog * [DDW-854] Update message for verifyng stage * [DDW-854] Update colors * [DDW-796] Refactor and voting phases * [DDW-796] Remove closed voting logic * [DDW-796] Exclude js/ts files from nix-build glob * [DDW-796] Fund phase logic * [DDW-796] Fund phase components * [DDW-796] Fix lint issues * [DDW-796] Fix flow issues * [DDW-796] Style fix * [DDW-796] Add observer * [DDW-796] Remove unused * [DDW-796] Lazy validation * [DDW-796] Update text * [DDW-858] Fix eslint warnings * [DDW-796] Add jp translations * [DDW-796] Enable voting in all env for testing only * [DDW-796] Add function for external link * [DDW-796] Review changes * [DDW-796] VotingStore unit test * [DDW-796] Update story * [DDW-796] Test only * Revert "[DDW-796] Test only" This reverts commit 3140b65. * Revert "[DDW-796] Enable voting in all env for testing only" This reverts commit 454c7e1. * [DDW-779] Update trezor connect to the official 8.2.3-extended version * [DDW-779] Remove bigi from MacInstaller * [DDW-779] Remove bigi from MacInstaller * [DDW-779] Remove bigi from MacInstaller * [DDW-779] Remove bytebuffer-old-fixed-webpack from MacInstaller * [DDW-779] Add babel-runtime 7.12.5 to yarn.lock * [DDW-854] Remove opacity property * [DDW-779] Rebuild yarn.lock * [DDW-779] Add protobufjs and bytebuffer to MacInstaller * [DDW-854] Added flow return type * [DDW-779] Update trezor-connect to 8.2.3-beta.8 version * Fixed duplicated text, wrong order * Bump version to 4.6.0 (#2780) * Removed RTS Flags from CHANGELOG * Bump version to 4.6.0 * [DDW-779] Update trezor-connect to v.8.2.4-extended and fix MacInstaller/yarn2nix * [DDW-779] Remove protobufjs from MacInstaller/yarn2nix * [DDW-779] Add @protobufjs * [DDW-779] CHANGELOG update * [DDW-821] Update packages with vulnerabilities (#2769) * [DDW-821] Upgrade packages with vulnerabilities * [DDW-821] Update node headers SHA checksum * [DDW-821] Update CHANGELOG.md * [DDW-821] Upgrade packages with vulnerabilities * [DDW-821] Update node headers SHA checksum * [DDW-821] Update CHANGELOG.md * [DDW-821] Downgrade electron-rebuild * Revert "[DDW-821] Downgrade electron-rebuild" This reverts commit ce4eabb. * Run lockfile:fix * Revert "Revert "[DDW-821] Downgrade electron-rebuild"" This reverts commit debe1c3. * [DDW-821] upgrate low severity vulnerabilities * [DDW-821] align babel config for private methods, class properties and object properties * [DDW-821] Remove explicit resolve-url installation * [DDW-821] Replace deprecated babel-eslint with @babel/eslint-parser * [DDW-821] Fix eslint error by wrapping util script in IIFE * [DDW-821] Fix yarn.lock Co-authored-by: Michael Chappell <michael.chappell@iohk.io> Co-authored-by: Tomislav Horaček <tomislav@tt-media.hr> * [DDW-874] Update README with nix.conf for Apple M1 (only for development purposes) (#2792) * [DDW-874] Update README with nix.conf for Apple M1 * [DDW-874] Update README - simplify nix.conf for M1 chip * [DDW-874] Update README nix.conf Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * [DDW-742] Fix receiver address validation (disallow rewards address) (#2781) * [DDW-882] Update cardano-wallet and cardano-node (#2799) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * [DDW-857][DEBT] Integrate Chromatic (#2776) * [DDW-893] Update the PR checklist (#2811) * [DDW-892] Use fresh locale while rebuilding the application menu (#2813) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * Update develop with release 4.7.0 (#2819) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> Co-authored-by: Lucas <lucas.araujo@iohk.io> Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io> * [DDW-891] update cardano-node to 1.33.0 (#2822) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * [DDW-916] Change the message for syncing the blockchain (#2827) * [DDW-916] Update second message on the initial screen to in include part regarding the waiting time (#2831) * [DDW-862] Enable dynamic RTS flags setting (#2758) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Marcin Mazurek <marcin.mazurek@iohk.io> * Bump version to 4.8.0 * [DDW-918] Update blockchain verification progress (#2840) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> Co-authored-by: Szymon Masłowski <szymon.maslowski@iohk.io> * [DDW-920] RTS flags UI/UX improvements (#2842) Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * [DDW-867] Check disk space (release ver) (#2845) Work originally done by @lucas-barros all credits to him * [DDW-920] Reduce the RAM threshold for RTS mode recommendation (#2846) * [DDW-920] Missing Japanese translations for RTS flags (#2848) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> Co-authored-by: Dominik Guzei <dominik.guzei@gmail.com> Co-authored-by: Nikola Glumac <niglumac@gmail.com> Co-authored-by: Tomislav Horaček <tomislav@tt-media.hr> Co-authored-by: Michael Bishop <michael.bishop@iohk.io> Co-authored-by: Daniel Main <daniel.main.cernhoff@icould.com> Co-authored-by: Renan Ferreira <renan.ferreira@iohk.io> Co-authored-by: Lucas <lukas_barros@hotmail.com> Co-authored-by: Lucas Araujo <lucas.araujo@iohk.io> Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Przemysław Włodek <przem.wlodek.github@gmail.com> Co-authored-by: Marcin Mazurek <marcin@mazurek.pro> Co-authored-by: Szymon Masłowski <i.am.szymon.maslowski@gmail.com> Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io> Co-authored-by: Szymon Masłowski <szymon.maslowski@iohk.io> Co-authored-by: Marcin Mazurek <marcin.mazurek@iohk.io>

…2781)

@lucas-barros

* Added jest and couple of unit tests for DDW-706 * Applied code review suggestions * Fixed wrong dependencies * Added a new test and a default config file * unicode-property pump * [DDW-706] Move new jest specs into tests folder * [DDW-706] Add Github action workflow for jest tests * Fix build issues * [DDW-706] Use supported node version in Github actions * [DDW-706] fix github action node version * Fix yarn.lock * Fix CI issues * Fix CI issues * downgrade to jest 26 * fix lockfile * Testing adding the conflict dependency as primary * Downgrade of istanbul-lib-report * [DDW-735] Merge and gix conflicts * [DDW-735] Merge and fix conflicts * [DDW-779] Update trezor-connect to the latest version 8.2.2-rc.1-multisig * [DDW-779] Add util-deprecate to yarn2nix * [DDW-815] Fix broken Ledger support on Linux (#2741) * fix yarn dev on linux * fix ledger on linux * [DDW-815] Adds CHANGELOG entery * fix windows builds * remove LD_PRELOAD to make the code more stable Co-authored-by: Nikola Glumac <niglumac@gmail.com> * Fix wallet restore dialog and continue disable check (#2745) * Fix walleFix wallet restore dialog and continue disable check * Updated CHANGELOG Co-authored-by: Nikola Glumac <niglumac@gmail.com> * Updated CHANGELOG.md * Change istanbul-lib-report resolution to 3.0.0 * Revert "Change istanbul-lib-report resolution to 3.0.0" This reverts commit 9f63133. * Reverted bump * Reverted bump * [DDW-779] Update trezor-connect to the 8.2.3-beta.3 version * [DDW-779] Remove hd-wallet from yarn2nix * [DDW-779] Update yarn.lock * [DDW-779] Remove hw-wallet from MacInstaller * [DDW-779] Remove merkle-lib from MacInstaller * [DDW-779] Remove multiple sub-dependencies from MacInstaller * [DDW-779] Remove secp256k1 from yarn2nix * [DDW-779] Replace secp256k1 with tiny-secp256k1 in yarn2nix * Merges release/4.5.1 into release/4.5.0 * Fixes CHANGELOG link * [DDW-779] Remove tiny-secp256k1 from yarn2nix * [DDW-779] Add bech32 to yarn2nix * [DDW-779] Add blake-hash to yarn2nix * [DDW-779] Add blake-hash to MacInstaller * [DDW-779] Add tiny-secp256k1 to MacInstaller * [DDW-779] Add bn.js to MacInstaller * [DDW-779] Add elliptic to MacInstaller * [DDW-779] Add minimalistic-assert to MacInstaller * [DDW-779] Add minimalistic-crypto-utils to MacInstaller * [DDW-779] Add minimalistic-crypto-utils to MacInstaller * [DDW-779] Add brorand to MacInstaller * [DDW-779] Add hash.js and hmac-drbg to MacInstaller * [DDW-779] Add int64-buffer to MacInstaller * [DDW-771] Add apache license to npm package * [DDW-771] Remove apache license from package.json again * [DDW-771] refactor to multi-line template literals * [DDW-811] Normalize checkbox tick offset * [DDW-824] Introduce a fix for app update on specific platform * [DDW-824] Improve faked data loading * [DDW-824] CHANGELOG update * [DDW-824] Remove unnecessary comment * fix linux build * [DDW-847] Bump CWB to v2021-11-11 * [DDW-847] CHANGELOG update * [DDW-683] Adjusted slider onAfterChange * [DDW-683] Updated CHANGELOG * [DDW-683] Converted component from class to functional * Removed unstable rts flags * [DDW-824] Restrict FAKED news QA loader to DEV mode only * [DDW-785] Discreet mode - Create the Discreet Mode variables * [DDW-738] Setup feature-driven design Co-authored-by: Lucas <lukas_barros@hotmail.com> Co-authored-by: Dominik Guzei <dominik.guzei@gmail.com> * [DDW-813] Move discreet mode behavior to its own feature * [DDW-738] Fix circular dependency * [DDW-786] Discreet mode - Create the TopBar icon (#2725) * [DDW-786] Added discreet mode toggle component * [DDW-789] Remove specific styles from component * [DDW-789] Fix translations * [DDW-789] CHANGELOG * [DDW-789] Fix eslint issue * [DDW-789] Remove popover theme variables * [DDW-789] Increase height for hide icon * [DDW-789] Remove style * [DDW-789] Rearrange icons to group by action or info * [DDW-786] Add japanese translations * [DDW-786] Rearrange icons order * [DDW-786] Add opacity * [DDW-786] Add isDiscreetMode control to story * [DDW-786] Fix gap width * [DDW-786] Fix default message * [DDW-786] Update to use mobx feature pattern * [DDW-786] Fix style * [DDW-738] Move toggle component to discreet mode feature folder * [DDW-738] Update translations file * [DDW-738] Remove popOver from DiscreetToggle * [DDW-814] Discreet mode - hide sensitive information (#2742) * [DDW-814] Fix React Dev Tools installation * [DDW-814] Hide sensitive values * [DDW-814] Setup storybook * [DDW-814] Localstorage factory * [DDW-814] Hide token amount for decimal config * [DDW-814] Refactor discreet mode ui components * [DDW-814] Directly use discreet mode feature in toggle * [DDW-814] Introduce configurable replacer pattern * [DDW-814] Create LocalStorageFeatureProvider * [DDW-814] Fix flow * [DDW-814] Fix topbar * [DDW-814] React to state changes on WalletUTXO description * [DDW-814] Preseve Stake pools ranking slider value * [DDW-814] Hide filter input * [DDW-814] Prevent stake pools from refreshing * [DDW-814] Update README * [DDW-814] Hide wallets dropdown in discreet mode * [DDW-814] Disable All transactions button on Filter dialog * [DDW-814] Rename DiscreetToggle component * [DDW-814] Add unit tests for discreet replacers * [DDW-814] Cleanup minor issues * [DDW-814] Fix prettier * [DDW-814] Revert istanbul * [DDW-814] Fix flow errors * [DDW-814] Add discreet toggle mode knob Co-authored-by: Dominik Guzei <dominik.guzei@gmail.com> * [DDW-787] Discreet mode - Implement the Settings option (#2740) * [DDW-785] Discreet mode - Create the Discreet Mode variables * [DDW-786] Discreet mode - Create the TopBar icon (#2725) * [DDW-786] Added discreet mode toggle component * [DDW-789] Remove specific styles from component * [DDW-789] Fix translations * [DDW-789] CHANGELOG * [DDW-789] Fix eslint issue * [DDW-789] Remove popover theme variables * [DDW-789] Increase height for hide icon * [DDW-789] Remove style * [DDW-789] Rearrange icons to group by action or info * [DDW-786] Add japanese translations * [DDW-786] Rearrange icons order * [DDW-786] Add opacity * [DDW-786] Add isDiscreetMode control to story * [DDW-786] Fix gap width * [DDW-786] Fix default message * [DDW-786] Update to use mobx feature pattern * [DDW-786] Fix style * [DDW-787] Implement discreet mode settings * [DDW-787] Fix text * [DDW-787] Add story * [DDW-787] Update translations * [DDW-787] Update translations * [DDW-787] Discreet mode tooltip local storage setting * [DDW-787] NotificationPopOver component * [DDW-787] Migrate Sidebar to functional component * [DDW-787] Wrap categories with NotificationPopOver * [DDW-787] Fix lint * [DDW-787] Add new placements * [DDW-787] Add default translations * [DDW-787] Adjust styles * [DDW-787] One time fixed popOver * [DDW-787] Add red dot to discreet mode settings * [DDW-787] Update initial translations * [DDW-787] Add styles specific for language * [DDW-787] Update action text * [DDW-787] Review changes * [DDW-787] Update translations * [DDW-787] Changelog * [DDW-787] Fix tooltip showing after accessing security tab * [DDW-787] Fix notification dot click * [DDW-787] Fix jumping icons * [DDW-787] Add jp translation * [DDW-787] Fix styling issues * [DDW-787] Remove red dot when user leaves security tab * [DDW-787] Fix tooltip overlap * [DDW-787] Fix click through tooltip * [DDW-787] Fix tooltip overlap dialogs * [DDW-787] Fix prettier issue * [DDW-787] Dismiss tooltip on route leave * [DDW-787] Fix tooltip overlaping issues * [DDW-787] Fix closing discreet mode popover on staking page * [DDW-787] Fix merge conflicts * [DDW-787] Move condition to const * [DDW-787] Move trigger component to stand alone hook * [DDW-787] Fix type import * [DDW-787] Remove unused * [DDW-787] Review changes Co-authored-by: Renan Ferreira <renan.ferreira@iohk.io> * [DDW-738] Notification knob * [DDW-839] Discreet mode - automated tests (#2756) * [DDW-839] Discreet mode integration tests * [DDW-839] Remove aria-query from yarnlock * [DDW-839] Remove istanbul from yarnlock * [DDW-839] Tests for public api * [DDW-839] Run lockfile:fix * [DDW-839] Update changelog * [DDW-738] Fix font weights * [DDW-738] Fix button style * [DDW-738] Fix button style * [DDW-738] Pin package version * [DDW-738] Fix name/icon overlapping * [DDW-738] Update yarn.lock * [DDW-738] Review changes * [DDW-738] Fix yarn.lock * [DDW-738] Review changes * [DDW-738] Review changes - use lang selector * [DDW-738] Fix flow issue * [DDW-738] Fix discreet mode logic on filter component * [DDW-854] Init * [DDW-854] New line * [DDW-854] Adjustments * [DDW-854] Update copy * [DDW-854] Small fix * [DDW-854] Small adjustment * [DDW-854] Update icon size * [DDW-854] Fix sass lint * [DDW-854] Update description color * [DDW-854] Update changelog * [DDW-854] Update changelog * [DDW-854] Update message for verifyng stage * [DDW-854] Update colors * [DDW-796] Refactor and voting phases * [DDW-796] Remove closed voting logic * [DDW-796] Exclude js/ts files from nix-build glob * [DDW-796] Fund phase logic * [DDW-796] Fund phase components * [DDW-796] Fix lint issues * [DDW-796] Fix flow issues * [DDW-796] Style fix * [DDW-796] Add observer * [DDW-796] Remove unused * [DDW-796] Lazy validation * [DDW-796] Update text * [DDW-858] Fix eslint warnings * [DDW-796] Add jp translations * [DDW-796] Enable voting in all env for testing only * [DDW-796] Add function for external link * [DDW-796] Review changes * [DDW-796] VotingStore unit test * [DDW-796] Update story * [DDW-796] Test only * Revert "[DDW-796] Test only" This reverts commit 3140b65. * Revert "[DDW-796] Enable voting in all env for testing only" This reverts commit 454c7e1. * [DDW-779] Update trezor connect to the official 8.2.3-extended version * [DDW-779] Remove bigi from MacInstaller * [DDW-779] Remove bigi from MacInstaller * [DDW-779] Remove bigi from MacInstaller * [DDW-779] Remove bytebuffer-old-fixed-webpack from MacInstaller * [DDW-779] Add babel-runtime 7.12.5 to yarn.lock * [DDW-854] Remove opacity property * [DDW-779] Rebuild yarn.lock * [DDW-779] Add protobufjs and bytebuffer to MacInstaller * [DDW-854] Added flow return type * [DDW-779] Update trezor-connect to 8.2.3-beta.8 version * Fixed duplicated text, wrong order * Bump version to 4.6.0 (#2780) * Removed RTS Flags from CHANGELOG * Bump version to 4.6.0 * [DDW-779] Update trezor-connect to v.8.2.4-extended and fix MacInstaller/yarn2nix * [DDW-779] Remove protobufjs from MacInstaller/yarn2nix * [DDW-779] Add @protobufjs * [DDW-779] CHANGELOG update * [DDW-821] Update packages with vulnerabilities (#2769) * [DDW-821] Upgrade packages with vulnerabilities * [DDW-821] Update node headers SHA checksum * [DDW-821] Update CHANGELOG.md * [DDW-821] Upgrade packages with vulnerabilities * [DDW-821] Update node headers SHA checksum * [DDW-821] Update CHANGELOG.md * [DDW-821] Downgrade electron-rebuild * Revert "[DDW-821] Downgrade electron-rebuild" This reverts commit ce4eabb. * Run lockfile:fix * Revert "Revert "[DDW-821] Downgrade electron-rebuild"" This reverts commit debe1c3. * [DDW-821] upgrate low severity vulnerabilities * [DDW-821] align babel config for private methods, class properties and object properties * [DDW-821] Remove explicit resolve-url installation * [DDW-821] Replace deprecated babel-eslint with @babel/eslint-parser * [DDW-821] Fix eslint error by wrapping util script in IIFE * [DDW-821] Fix yarn.lock Co-authored-by: Michael Chappell <michael.chappell@iohk.io> Co-authored-by: Tomislav Horaček <tomislav@tt-media.hr> * [DDW-874] Update README with nix.conf for Apple M1 (only for development purposes) (#2792) * [DDW-874] Update README with nix.conf for Apple M1 * [DDW-874] Update README - simplify nix.conf for M1 chip * [DDW-874] Update README nix.conf Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * [DDW-742] Fix receiver address validation (disallow rewards address) (#2781) * [DDW-882] Update cardano-wallet and cardano-node (#2799) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * [DDW-857][DEBT] Integrate Chromatic (#2776) * [DDW-893] Update the PR checklist (#2811) * [DDW-892] Use fresh locale while rebuilding the application menu (#2813) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * Update develop with release 4.7.0 (#2819) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> Co-authored-by: Lucas <lucas.araujo@iohk.io> Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io> * [DDW-891] update cardano-node to 1.33.0 (#2822) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * [DDW-916] Change the message for syncing the blockchain (#2827) * [DDW-916] Update second message on the initial screen to in include part regarding the waiting time (#2831) * [DDW-862] Enable dynamic RTS flags setting (#2758) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Marcin Mazurek <marcin.mazurek@iohk.io> * Bump version to 4.8.0 * [DDW-918] Update blockchain verification progress (#2840) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> Co-authored-by: Szymon Masłowski <szymon.maslowski@iohk.io> * [DDW-920] RTS flags UI/UX improvements (#2842) Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> * [DDW-867] Check disk space (release ver) (#2845) Work originally done by @lucas-barros all credits to him * [DDW-920] Reduce the RAM threshold for RTS mode recommendation (#2846) * [DDW-920] Missing Japanese translations for RTS flags (#2848) Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com> Co-authored-by: Dominik Guzei <dominik.guzei@gmail.com> Co-authored-by: Nikola Glumac <niglumac@gmail.com> Co-authored-by: Tomislav Horaček <tomislav@tt-media.hr> Co-authored-by: Michael Bishop <michael.bishop@iohk.io> Co-authored-by: Daniel Main <daniel.main.cernhoff@icould.com> Co-authored-by: Renan Ferreira <renan.ferreira@iohk.io> Co-authored-by: Lucas <lukas_barros@hotmail.com> Co-authored-by: Lucas Araujo <lucas.araujo@iohk.io> Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Przemysław Włodek <przem.wlodek.github@gmail.com> Co-authored-by: Marcin Mazurek <marcin@mazurek.pro> Co-authored-by: Szymon Masłowski <i.am.szymon.maslowski@gmail.com> Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io> Co-authored-by: Szymon Masłowski <szymon.maslowski@iohk.io> Co-authored-by: Marcin Mazurek <marcin.mazurek@iohk.io>

…2781)

[DDW-742] Fix receiver address validation (disallow stake address)

4246ce5

przemyslaw-wlodek added bug ⏳release-vNext labels Dec 9, 2021

[DDW-742] Update changelog

7b235d1

przemyslaw-wlodek requested review from a team December 9, 2021 16:49

przemyslaw-wlodek added the WIP label Dec 10, 2021

przemyslaw-wlodek self-assigned this Dec 13, 2021

przemyslaw-wlodek and others added 6 commits December 18, 2021 01:00

[DDW-742] Update cardano-wallet and use address_type field in receive…

90ae542

…r validation

Bump version to 4.6.0 (#2780)

a6097a1

* Removed RTS Flags from CHANGELOG * Bump version to 4.6.0

[DDW-742] Update changelog

b376f8b

Merge remote-tracking branch 'origin/develop' into fix/ddw-742-fix-re…

b3ca81f

…ceiver-address-validation

[DDW-742] Move address_type property to AddressBase interface

785a2a4

[DDW-742] Post-merge changelog update

93e2e7e

przemyslaw-wlodek removed the WIP label Dec 18, 2021

przemyslaw-wlodek changed the title ~~[DDW-742] Fix receiver address validation (disallow stake address)~~ [DDW-742] Fix receiver address validation (disallow rewards address) Dec 21, 2021

[DDW-742] Remove Jormungandr from address-introspection types (deprec…

d5bf6fc

…ated)

ManusMcCole approved these changes Dec 21, 2021

View reviewed changes

renanvalentin reviewed Dec 22, 2021

View reviewed changes

source/renderer/app/utils/hardwareWalletUtils.js Outdated Show resolved Hide resolved

przemyslaw-wlodek added 3 commits December 22, 2021 13:34

Merge remote-tracking branch 'origin/develop' into fix/ddw-742-fix-re…

7a400d4

…ceiver-address-validation

[DDW-742]: Optimize receiver address validation (review)

e207e6d

[DDW-742]: Fix lockfile

0a8769a

renanvalentin approved these changes Dec 22, 2021

View reviewed changes

miorsufianiohk approved these changes Dec 22, 2021

View reviewed changes

danielmain self-requested a review December 24, 2021 12:53

danielmain previously requested changes Dec 24, 2021

View reviewed changes

przemyslaw-wlodek and others added 3 commits December 29, 2021 14:02

Revert "[DDW-742]: Fix lockfile"

300a701

This reverts commit 0a8769a.

[DDW-742]: Use fixed dependency versions

4b66b8e

Merge branch 'develop' into fix/ddw-742-fix-receiver-address-validation

00486a9

danielmain merged commit 98c6fd4 into develop Dec 30, 2021

iohk-bors bot deleted the fix/ddw-742-fix-receiver-address-validation branch December 30, 2021 13:45

renanvalentin pushed a commit that referenced this pull request Jan 7, 2022

[DDW-742] Fix receiver address validation (disallow rewards address) (#…

6017298

…2781)

danielmain added release-4.7.0 Daedalus Mainnet and removed ⏳release-vNext labels Jan 19, 2022

renanvalentin pushed a commit that referenced this pull request Mar 7, 2022

[DDW-742] Fix receiver address validation (disallow rewards address) (#…

a076266

…2781)

renanvalentin pushed a commit that referenced this pull request Mar 7, 2022

[DDW-742] Fix receiver address validation (disallow rewards address) (#…

fd46ad5

…2781)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DDW-742] Fix receiver address validation (disallow rewards address) #2781

[DDW-742] Fix receiver address validation (disallow rewards address) #2781

przemyslaw-wlodek commented Dec 9, 2021 •

edited

Loading

ManusMcCole left a comment

renanvalentin left a comment

miorsufianiohk left a comment

danielmain left a comment

[DDW-742] Fix receiver address validation (disallow rewards address) #2781

[DDW-742] Fix receiver address validation (disallow rewards address) #2781

Conversation

przemyslaw-wlodek commented Dec 9, 2021 • edited Loading

Todos

Screenshots

Testing Checklist

Test Scenarios

Review Checklist

Basics

Code Quality

Testing

After Review

ManusMcCole left a comment

Choose a reason for hiding this comment

renanvalentin left a comment

Choose a reason for hiding this comment

miorsufianiohk left a comment

Choose a reason for hiding this comment

danielmain left a comment

Choose a reason for hiding this comment

przemyslaw-wlodek commented Dec 9, 2021 •

edited

Loading