Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-985] Missing character when copying address from PDF #2925

Merged
merged 5 commits into from Mar 22, 2022
Merged

[DDW-985] Missing character when copying address from PDF #2925

merged 5 commits into from Mar 22, 2022

Conversation

marcin-mazurek
Copy link
Contributor

@marcin-mazurek marcin-mazurek commented Mar 17, 2022 •
edited

This PR replaces the monospaced font used for rendering PDF address with Roboto Mono, which does not use ligatures that were causing issues with copying a wallet address from PDF.

User report: #2588

Screenshots

Before

Screenshot 2022-03-17 at 10 03 57
before.pdf

After

Screenshot 2022-03-17 at 10 04 02
after.pdf

Testing Checklist

Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • [NOT APPLICABLE] All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • [NOT APPLICABLE] Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • [NOT APPLICABLE] Japanese text changes are proofread and approved (Junko Oda)
  • [NOT APPLICABLE] Storybook works and no stories are broken (yarn storybook)
  • [NOT APPLICABLE] In case of dependency changes yarn.lock file is updated

Code Quality

  • [NOT APPLICABLE] Important parts of the code are properly commented and documented
  • [NOT APPLICABLE] Code is properly typed with typescript types
  • [NOT APPLICABLE] React components are split-up enough to avoid unnecessary re-renderings
  • [NOT APPLICABLE] Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@marcin-mazurek marcin-mazurek requested review from alexander-rukin and a team March 17, 2022 09:10
@marcin-mazurek marcin-mazurek self-assigned this Mar 17, 2022
@marcin-mazurek marcin-mazurek force-pushed the fix/ddw-985-missing-character-in-pdf branch from 7ec8de4 to e47113e Compare March 17, 2022 09:16
alexander-rukin
alexander-rukin approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@alexander-rukin alexander-rukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@marcin-mazurek marcin-mazurek mentioned this pull request Mar 17, 2022
Closed
@marcin-mazurek marcin-mazurek force-pushed the fix/ddw-985-missing-character-in-pdf branch from 2432ebe to 14f5e8c Compare March 17, 2022 15:55
@miorsufianiohk miorsufianiohk self-requested a review March 21, 2022 10:09
miorsufianiohk
miorsufianiohk approved these changes Mar 21, 2022
View reviewed changes
Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @marcin-mazurek 👍 . Tested on 21311

gabriela-ponce
gabriela-ponce approved these changes Mar 21, 2022
View reviewed changes
Copy link

@gabriela-ponce gabriela-ponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Tested with these addresses.

@danielmain danielmain merged commit e8ba793 into develop Mar 22, 2022
@danielmain danielmain deleted the fix/ddw-985-missing-character-in-pdf branch March 22, 2022 19:23
lucas-barros pushed a commit that referenced this pull request Apr 25, 2022
@danielmain @lucas-barros
Merge pull request #2925 from input-output-hk/fix/ddw-985-missing-cha…
dabd060 
…racter-in-pdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-rukin alexander-rukin alexander-rukin approved these changes

@renanvalentin renanvalentin renanvalentin approved these changes

@danielmain danielmain danielmain approved these changes

@michalrus michalrus michalrus approved these changes

@gabriela-ponce gabriela-ponce gabriela-ponce approved these changes

@shawnbusuttil shawnbusuttil shawnbusuttil approved these changes

@miorsufianiohk miorsufianiohk miorsufianiohk approved these changes

Assignees

@marcin-mazurek marcin-mazurek

Labels
bug release-4.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@marcin-mazurek @alexander-rukin @renanvalentin @danielmain @michalrus @gabriela-ponce @shawnbusuttil @miorsufianiohk