Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Copying address from Daedalus Generated Address PDF breaks it #2588

Closed
AlexDochioiu opened this issue Jun 4, 2021 · 14 comments
Closed
Assignees
Labels

Comments

@AlexDochioiu
Copy link

Version: Daedalus 4.0.5
Issue: Copying the address from the PDF somehow removes one character(from the middle), making the address invalid.

This behaviour is consistent on both MacOS and Windows (did not test linux).

broken_address_daedalus.pdf

@nikolaglumac
Copy link
Contributor

@gabriela-ponce please investigate this on all 3 platforms 🙏

@AlexDochioiu
Copy link
Author

Might be worth mentioning that the PDF was open on macOS using Brave Browser (so the default Chromium PDF viewer). Not sure how it was opened on windows because it's not me who's tested there.

@gabriela-ponce
Copy link

gabriela-ponce commented Jun 4, 2021

Hi @AlexDochioiu, thanks for the report.
I've verified this on MacOS using Brave browser and I can confirm that this is a bug. These are the test that I ran:

1 - Copy the address from the document on another PDF reader and compare it with the same address copied from Brave. The latter was indeed missing a character. Check this video.
2 - Create a new PDF document containing the same address (without missing any character) and repeat test # 1. There was no difference between the addresses. Check this video.
3 - Check the difference between an address copied from Daedalus and the same address copied from a document on Brave Browser. No difference between those addresses. Check this video.

@nikolaglumac As this doesn't happen with other addresses, my conclusion is that there is something in this address that is causing one of the characters to be ignored. At the same time, it doesn't reproduce with other PDF documents using the same address, so it may be related to how the document is created.
I'll continue investigating this in Windows and Linux and share if the results are different.

@AlexDochioiu
Copy link
Author

@gabriela-ponce The person that generated this address tried it again on Daedalus 4.1.0 (Windows 10). The issue persists. He said that the address is copied poorly from Edge but works well when opening with Adobe Acrobat Reader.

My assumption is that there's a bug in the Chromium PDF Reader causing it. However, you might still want to find a workaround (maybe change something in how the PDF is generated) because that could be quite problematic.

@AlexDochioiu
Copy link
Author

AlexDochioiu commented Jun 4, 2021

@gabriela-ponce Update: I asked the person to generate PDFs on more addresses using the same wallet. They are all broken when opened with the Chromium PDF reader. Some of them are actually missing 2 characters.

@gabriela-ponce
Copy link

@AlexDochioiu Thank you for the additional information. I was able to reproduce this issue with the document attached to the original report on all platforms, using Brave, Chrome and Edge.
However, it didn't reproduce with the test document I created with the same address. Also couldn't reproduce this with any other wallet or in browsers like Safari and Firefox.
Just to double-check, does this issue reproduce only with this wallet? Do you have any other wallet that reproduces the same issue when generating PDFs?

@AlexDochioiu
Copy link
Author

@gabriela-ponce I asked the person to generate a PDF from another wallet. There was no problem. It seems that only that particular wallet has problems when generating PDFs.

@gabriela-ponce
Copy link

@AlexDochioiu Thanks for the information. In order to find the pattern that is causing this issue, could you send us a few of the PDF documents generated for this wallet? 10 different addresses for the wallet that is failing would be ok. If any of the address is copied correctly, please also include it so we can compare it with the rest.

@gabriela-ponce
Copy link

@AlexDochioiu Are you still reproducing this issue? If so, can you check my previous comment, please? Thank you!

@gabriela-ponce
Copy link

Hello @AlexDochioiu! I was wondering if you are still reproducing this issue. If so, please check this comment so we can get more information to address it. Thank you!

@AlexDochioiu
Copy link
Author

@gabriela-ponce I mentioned previously that it's not my wallet that had this issue. Unfortunately I cannot ask the person for more addresses.

@gabriela-ponce
Copy link

@AlexDochioiu As we need additional information to address this problem, I would recommend asking the user that is facing this issue to submit a support request from Daedalus, in case they can't access this thread (Access to Help - Support Request). They could attach these files at the bottom of the form.

@danielmain
Copy link
Contributor

Closed due to inactivity

@marcin-mazurek
Copy link
Contributor

PR that addresses the issue: #2925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants