Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-1165] Update configs for Preprod respin #3070

Merged
merged 2 commits into from
Oct 21, 2022
Merged

[DDW-1165] Update configs for Preprod respin #3070

merged 2 commits into from
Oct 21, 2022

Conversation

michalrus
Copy link
Member

@michalrus michalrus commented Oct 21, 2022 •
edited
Loading

This PR updates cardano-node configs for the respinning of the Preprod environment

Todos

  • is it enough to communicate to users that they have to remove the chain directory manually?

Screenshots

n/a

Testing Checklist

Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@michalrus michalrus force-pushed the chore/ddw-1165-preprod-respin branch from 91b802a to 5fdd7a6 Compare October 21, 2022 12:18
@michalrus michalrus self-assigned this Oct 21, 2022
@michalrus michalrus requested review from a team October 21, 2022 12:19
danielmain
danielmain approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@danielmain danielmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

tomislavhoracek
tomislavhoracek approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tgunnoe
Copy link
Member

tgunnoe commented Oct 21, 2022

This one is easy

@danielmain danielmain merged commit 49c073d into develop Oct 21, 2022
@iohk-bors iohk-bors bot deleted the chore/ddw-1165-preprod-respin branch October 21, 2022 14:33
@michalrus michalrus added release-5.1.1 Daedalus version 5.1.1 and removed ⏳release-vNext labels Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmain danielmain danielmain approved these changes

@tgunnoe tgunnoe tgunnoe approved these changes

@tomislavhoracek tomislavhoracek tomislavhoracek approved these changes

@miorsufianiohk miorsufianiohk Awaiting requested review from miorsufianiohk

@gabriela-ponce gabriela-ponce Awaiting requested review from gabriela-ponce

Assignees

@michalrus michalrus

Labels
cardano-node chore infrastructure release-5.1.1 Daedalus version 5.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalrus @tgunnoe @danielmain @tomislavhoracek