-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post tx-cost benchmark results verbatim into PR #340
Conversation
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Cost of Init Transaction
Cost of Commit TransactionUses ada-only UTxO for better comparability.
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Abort Transaction
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
e29313d
to
939216e
Compare
939216e
to
52a2da3
Compare
hydra-node/exe/tx-cost/TxCost.hs
Outdated
) | ||
where | ||
compute numUTxO sz = do | ||
-- FIXME: genSimpleUTxOOfSize only produces ada-only, so the separation of | ||
-- generating and resizing is moot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abailly-iohk what do you think about this? Shall we move to just ada-only
utxos and simplify the results by having a single dimension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, makes a lot of sense, let's do that
The results are not so useful and have been historically recorded in our reports and in #155
011008d
to
7f6429c
Compare
We had used ada-only outputs already so no point in having these two dimensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This begs for outputting the benchmark's results in JSON for easier manipulation and formatting, so that we can only publish the highest values for each type of tx but that's totally addressable in another PR
@@ -167,6 +167,51 @@ jobs: | |||
name: benchmarks-and-haddocks | |||
path: ./docs | |||
|
|||
publish-benchmark-results: | |||
name: Publish benchmark results | |||
# TODO: this is actually only requires the tx-cost benchmark results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: remove is
else pure Nothing | ||
) | ||
computeCloseCost = do | ||
interesting <- catMaybes <$> mapM compute [1, 2, 3, 5, 10, 30] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice variable name :)
Maybe the Merkle-tree results are a bit off-topic? We could move them back to the plutus-merkle-tree package and leave them there. |
6233e08
to
c4f03b2
Compare
…in plutus-merkle-tree.
c4f03b2
to
4eeaa0c
Compare
I would agree, but was not prioritizing this work for now. There is an item for this in our red bin Edit: I see you have addressed this. Nice |
❄️ Adds a github action to publish the benchmark results
❄️ Reduce number of data points in
tx-cost