Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'required' attribute to release job #536

Merged
1 commit merged into from
Oct 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 5, 2022

Thanks to @jbgi this PR fixes the notification we get in GH actions from Hydra-the-CI. What happened is the following:

  1. Hydra notifications reportedly errored on the Hydra side and Devops did not know why
  2. devops group was recently added as and admin for ALL IOHK repositories as a "Base level escalation access to IOG repos"
  3. This caused the notification to on the Hydra-the-CI side to succeed but it then reported a failure because there were no required builds in the release.nix configuration

Hydra-the-CI was configured for Hydra-the-layer-2 here: https://github.com/input-output-hk/ci-ops/blob/master/modules/hydra-master-main.nix#L47-L81

This PR fixes this configuration.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Unit Test Results

257 tests  ±0   251 ✔️ ±0   14m 15s ⏱️ - 1m 22s
  91 suites ±0       6 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit ba89d7d. ± Comparison against base commit ccb8242.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2022-10-05 11:14:06.281828675 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Cost of Init Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 4833 10.63 4.22 0.48
2 5037 14.01 5.55 0.53
3 5241 15.76 6.23 0.55
5 5652 18.23 7.13 0.60
10 6678 29.90 11.68 0.77
45 13854 98.88 38.25 1.83

Cost of Commit Transaction

Currently only one UTxO per commit allowed (this is about to change soon)

UTxO Tx size % max Mem % max CPU Min fee ₳
1 5771 19.83 8.01 0.62

Cost of CollectCom Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 13058 20.60 8.25 0.95
2 13450 37.33 15.12 1.15
3 13774 56.23 22.95 1.38
4 14022 76.75 31.47 1.61

Cost of Close Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 9331 8.19 3.36 0.65
2 9492 8.97 3.81 0.67
3 9657 9.75 4.27 0.68
5 9690 9.83 3.83 0.68
10 10881 15.99 7.73 0.81
30 14225 33.00 17.31 1.17
64 15606 38.36 14.53 1.25

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 9330 8.16 3.34 0.65
2 9493 8.94 3.79 0.67
3 9660 9.72 4.24 0.68
5 9990 11.28 5.15 0.72
10 10813 15.18 7.40 0.80
30 14221 32.42 17.07 1.16
43 16363 42.74 23.01 1.38

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 13563 23.36 9.68 1.01
2 13604 34.02 14.28 1.13
3 14139 58.64 25.61 1.43
4 14462 83.31 37.23 1.73
5 14360 95.44 41.55 1.85

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 13420 9.88 4.31 0.85
2 13584 12.46 5.61 0.89
3 13622 13.98 6.49 0.91
5 13563 15.96 7.83 0.93
10 13745 23.57 12.23 1.03
50 15177 84.50 47.45 1.84
60 15538 99.74 56.26 2.05

@jbgi jbgi force-pushed the abailly-iohk/fix-gh-hydra-interaction branch from f0257e4 to ba89d7d Compare October 5, 2022 11:02
@ghost ghost marked this pull request as ready for review October 5, 2022 12:38
@ghost ghost merged commit 876a4a2 into master Oct 5, 2022
@ghost ghost deleted the abailly-iohk/fix-gh-hydra-interaction branch October 5, 2022 16:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants