Add jcli command to tally all proposals in a vote plan #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merge shares from multiple members
zeegomo
force-pushed
the
offline-tally
branch
from
808f47c
to
c9d4b63
Compare
| proposals: usize, | ||
| ) -> Result<Vec<Vec<chain_vote::TallyDecryptShare>>, Error> { | ||
| let shares: Vec<Vec<String>> = serde_json::from_reader(io::open_file_read(share_path)?)?; | ||
| if shares[0].len() < threshold || shares.len() != proposals { |
There was a problem hiding this comment.
There is no guarantee that all underlying vectors are of correct length if shares[0].len() >= threshold is satisfied. IMO it is better to move that check to the .map() call below. I guess this pattern might be repeated in a few other places.
zeegomo
force-pushed
the
offline-tally
branch
from
0e83eec
to
44b843b
Compare
eugene-babichenko
approved these changes
Feb 4, 2021
mzabaluev
suggested changes
Feb 8, 2021
mzabaluev
approved these changes
Feb 9, 2021
jcli/src/jcli_app/vote/tally/mod.rs
Outdated
Comment on lines
38
to
41
| Tally::DecryptionShare(cmd) => cmd.exec(), | ||
| Tally::VotePlanDecryptionShares(cmd) => cmd.exec(), | ||
| Tally::DecryptionShares(cmd) => cmd.exec(), | ||
| Tally::Decrypt(cmd) => cmd.exec(), | ||
| Tally::DecryptVotePlan(cmd) => cmd.exec(), | ||
| Tally::DecryptResults(cmd) => cmd.exec(), |
There was a problem hiding this comment.
I wonder if we could hide the deprecated commands from help, but still have them supported in the CLI.
There was a problem hiding this comment.
Can we remove them altogether once we have tested the new ones? I do not see much value in keeping those, and we would have to maintain more functionalities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am keeping the old commands for compatibility reasons and I would like to remove them if not needed, but I think they are used in tests at the moment.
Intermediate steps outputs (generate shares, tally private vote) are only needed for inter-command communication, it probably makes sense if the format is fixed (i.e. always in json)
Working on decrypt shares I got a bit confused by
Vec<Vec<Share>>orVec<Share>since it's not obvious what the structure of that is, and they actually mean different things in different contexts (e.g. isVec<Share>all the shares for a vote plan of a committee member or is it all the shares of multiple committee members for a single proposal), so I added some more types to clarify that.This pr is becoming quite big, I don't know what the policy is, if I should split it up or navigating diffs by commits is enough.
First step for #2972