Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check update for audit-check #3277

Merged
merged 1 commit into from May 10, 2021
Merged

check update for audit-check #3277

merged 1 commit into from May 10, 2021

Conversation

eugene-babichenko
Copy link
Contributor

@eugene-babichenko eugene-babichenko commented May 7, 2021

demonstation of fixed security audit

@eugene-babichenko eugene-babichenko added the DO NOT MERGE not to be merged until something else is done label May 7, 2021
@eugene-babichenko eugene-babichenko removed the DO NOT MERGE not to be merged until something else is done label May 7, 2021
@eugene-babichenko eugene-babichenko marked this pull request as ready for review May 7, 2021 11:33
@mzabaluev
Copy link
Contributor

#3284 should fix the cause of audit failures.

I'm not sure we should continue using this action, though: last release/commit was a year ago, and actions-rs/audit-check#163 has stayed unfixed for months despite obvious security implications.

@mzabaluev
Copy link
Contributor

Filed actions-rs/meta#35

Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this, it's unlikely the upstream will get any important updates soon.

@mzabaluev mzabaluev merged commit 1884a6d into master May 10, 2021
@mzabaluev mzabaluev deleted the test-fixed-audit branch May 10, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants