Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async traits update #3366

Merged
merged 3 commits into from Jun 8, 2021
Merged

Async traits update #3366

merged 3 commits into from Jun 8, 2021

Conversation

zeegomo
Copy link
Contributor

@zeegomo zeegomo commented Jun 8, 2021

Extract the try_join macro call to an external function as a workaround for dtolnay/async-trait#144 and update async-trait to 0.1.50

mzabaluev
mzabaluev approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring out the minimal workaround!

@mzabaluev mzabaluev added cleaning PRs about cleanup some imports, comments, and code golfing technical debt issue to track potential technical dept we are introducing but will need care later. labels Jun 8, 2021
@mzabaluev mzabaluev merged commit a09e3af into input-output-hk:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzabaluev mzabaluev mzabaluev approved these changes

Assignees
No one assigned
Labels
cleaning PRs about cleanup some imports, comments, and code golfing technical debt issue to track potential technical dept we are introducing but will need care later.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zeegomo @mzabaluev