New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add leadership management REST API #654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeSandwich
added
enhancement
New feature or request
subsys-rest
issues or PRs for the REST interface
labels
Jul 25, 2019
CodeSandwich
force-pushed
the
rest_leaders_list
branch
from
July 25, 2019 14:56
8531424
to
3df4dba
Compare
vincenthz
reviewed
Jul 31, 2019
@@ -23,6 +24,7 @@ pub struct Context { | |||
pub transaction_task: Arc<Mutex<MessageBox<TransactionMsg>>>, | |||
pub logs: Arc<Mutex<Logs>>, | |||
pub server: Arc<RwLock<Option<Server>>>, | |||
pub enclave: Enclave, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a big fan of this for fencing purpose, but for now it will do (and can be properly fenced later)
vincenthz
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-api
Area: Control and status API
enhancement
New feature or request
subsys-rest
issues or PRs for the REST interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412