Update stats and scenario testing #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NicolasDP
commented
Aug 29, 2019
•
NicolasDP
commented
- missing: update the open API doc
NicolasDP
added
A-tests
mzabaluev
reviewed
Aug 30, 2019
| @@ -133,3 +133,67 @@ pub fn scenario_1(mut context: Context<ChaChaRng>) { | |||
|
|
|||
| controller.finalize(); | |||
| } | |||
|
|
|||
| pub fn scenario_2(mut context: Context<ChaChaRng>) { | |||
There was a problem hiding this comment.
Could the name be more informative as to what the scenario tests?
There was a problem hiding this comment.
nop. they will be cleaned up when I have a better control of the different scenario and their execution
| @@ -55,7 +55,7 @@ fn main() { | |||
|
|
|||
| introduction(&context); | |||
|
|
|||
| scenario_1(context.derive()); | |||
| scenario_2(context.derive()); | |||
There was a problem hiding this comment.
Has scenario_1 fallen into dead code then?
| pub fn address(&self, discrimination: Discrimination) -> Address { | ||
| self.identifier().to_address(discrimination).into() | ||
| } | ||
|
|
||
| pub fn increment_counter(&mut self) { | ||
| let v : u32 = self.internal_counter.into(); | ||
| self.internal_counter = account::SpendingCounter::from(v + 1); |
There was a problem hiding this comment.
SpendingCounter might benefit from an impl of AddAssign to simplify this.
NicolasDP
force-pushed
the
update-stats-and-scenario-testing
branch
from
de0c02a
to
a753df5
Compare
NicolasDP
force-pushed
the
update-stats-and-scenario-testing
branch
from
a753df5
to
8a2e88e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.