Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the node use multiaddr for the listen_addr #736

Merged
merged 2 commits into from Sep 3, 2019
Merged

make the node use multiaddr for the listen_addr #736

merged 2 commits into from Sep 3, 2019

Conversation

NicolasDP
Copy link
Contributor

No description provided.

@NicolasDP NicolasDP added subsys-network network related A-jormungandr Area: Issues affecting jörmungandr labels Sep 3, 2019
@NicolasDP NicolasDP self-assigned this Sep 3, 2019
mzabaluev
mzabaluev approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't really see much benefit for changing this, though; the existing option harmonizes with the similar setting for the REST service.

@NicolasDP NicolasDP merged commit 33f7c74 into master Sep 3, 2019
@NicolasDP NicolasDP deleted the fix-network-settings branch September 3, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzabaluev mzabaluev mzabaluev approved these changes

Assignees

@NicolasDP NicolasDP

Labels
A-jormungandr Area: Issues affecting jörmungandr subsys-network network related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NicolasDP @mzabaluev