nix: remove old niv code paths & various fixes #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrdxp
force-pushed
the
remove-niv
branch
2 times, most recently
from
4649f04
to
33d3fc0
Compare
jvdp
reviewed
Aug 24, 2021
jvdp
approved these changes
Aug 24, 2021
leo-bogastry
approved these changes
Aug 26, 2021
* Use flake-compat so sources are same for stable/unstable users * completely remove niv * add envrc for direnv users * add retesteth to devshell, and unify flake devShell and shell.nix
nrdxp
force-pushed
the
develop
branch
6 times, most recently
from
22e35b2
to
63187a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was requested to add retesteth to the Nix shell, and I discovered a lot of inconsistency and stale code, so I cleaned it up as best I could.
Proposed Solution
We don't use Niv, so remove all mention of it, pull sources exclusively using the flake, and use flake-compat to pull them out for stable Nix users (like the buildkite).
Important Changes Introduced
The most important thing is to make sure CI still passes since we no longer use some of the old niv pins, and also to make sure I didn't overlook anything. Once it is green, it should be ready to merge.