Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Streamer returns ChainScannedBlocks #1704

Closed
2 tasks done
jpraynaud opened this issue May 22, 2024 · 0 comments · Fixed by #1716
Closed
2 tasks done

Block Streamer returns ChainScannedBlocks #1704

jpraynaud opened this issue May 22, 2024 · 0 comments · Fixed by #1716
Assignees
@sfauvel @dlachaume
Labels
feature 🚀 New implemented feature

Comments

@jpraynaud
Copy link
Member

jpraynaud commented May 22, 2024 •
edited by dlachaume
Loading

Why

We need the block scanners to return list of ChainBlockNextActions instead of Vec<ScannedBlock> in order to be able to handle rollbacks.

What

Adapt the BlockStreamer interface and implementations to return a ChainScannedBlocks (name TBD):

enum ChainScannedBlocks {
  RollForwards(Vec<ScannedBlock>),
  RollBackward(ChainPoint)
}

How

  • Adapt BlockStreamer trait and implementations
  • Adapt TransactionsImporter accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfauvel sfauvel

@dlachaume dlachaume

Labels
feature 🚀 New implemented feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update BlockStreamer return type input-output-hk/mithril
3 participants
@sfauvel @jpraynaud @dlachaume