Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pooled resources should be reset when given back #1743

Closed
3 tasks done
jpraynaud opened this issue Jun 11, 2024 · 0 comments · Fixed by #1744
Closed
3 tasks done

Pooled resources should be reset when given back #1743

jpraynaud opened this issue Jun 11, 2024 · 0 comments · Fixed by #1744
Assignees
Labels
optimization 🛠️ Optimization and/or small enhancements

Comments

@jpraynaud
Copy link
Member

Why

When resources are given back to a resource pool (e.g. Merkle maps in the Cardano transaction prover), they need to be reset properly (e.g. the Merkle map should be compressed so that all its values are represented by their root). This will guarantee that pooled resources are consistent and do not depend from previous computations. (e.g. this will avoid the risk of memory overflow and provide a consistent proving time).

What

Design a reset behavior for pooled resources, and implement it for Merkle maps.

How

  • Make the pooled resources of ResourcePool implement a Reset trait
  • Implement the Reset trait for the Merkle map with its compression
  • Benchmark the performances of the prover
@jpraynaud jpraynaud self-assigned this Jun 11, 2024
@jpraynaud jpraynaud added the optimization 🛠️ Optimization and/or small enhancements label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization 🛠️ Optimization and/or small enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant