fix(NFT Images): Support array image types for CIP-68 #922
Conversation
Per the recommendation of the pool.pm team and in compliance with metadata standards, we sometimes see NFT IPFS links represented as arrays of strings. These arrays are meant to be concatenated directly to produce the IPFS link (or data scheme, etc.). Because the image is retrieved in the send assets page, without this change users are UNABLE to send assets in CIP-68 format (since the decimals do not get properly set in `nami/src/api/extension/index.js#1762`). [ Testing: npm test, manually built and submitted tx from Nami ] [ Test Artifacts: txn 5e342b856efa596da433e3eec4256809cfe9bd9c4c9c39eb316328080ced13f1 ]
|
@rhyslbw @VanessaPC @DominikGuzei @bslabiak would love any attention you might be able to give to this as it is impacting current minters of NFTs on CIP-68. There is a large collection just minted (Galacticats) where assets are frozen in individuals' wallets. |
|
Thank you for the fix. We'll test and include in release we're currently preparing |
|
Note: @thaddeusdiamond, I ("pool.pm team") never gave recommendations about CIP68 and string arrays (string arrays in CIP25 are in the spec so it's a different matter), please don't pseudo quote without sources. Thank you. |
|
Fair, I guess I should have worded it as "Per the current behavior of JPG and Pool.PM software" but it must have slipped my mind. Just wanted to show that this Nami behavior is breaking NFTs for folks that are using other ecosystem dApps. Poor wording, my bad. |
Per the recommendation of the pool.pm team and in compliance with metadata standards, we sometimes see NFT IPFS links represented as arrays of strings. These arrays are meant to be concatenated directly to produce the IPFS link (or data scheme, etc.).
Because the image is retrieved in the send assets page, without this change users are UNABLE to send assets in CIP-68 format (since the decimals do not get properly set in
nami/src/api/extension/index.js#1762).[ Testing: npm test, manually built and submitted tx from Nami ]
[ Test Artifacts: txn 5e342b856efa596da433e3eec4256809cfe9bd9c4c9c39eb316328080ced13f1 ]