Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slides-ci workflow failure #671

Closed
lesteve opened this issue Nov 7, 2022 · 3 comments
Closed

slides-ci workflow failure #671

lesteve opened this issue Nov 7, 2022 · 3 comments

Comments

@lesteve
Copy link
Collaborator

lesteve commented Nov 7, 2022

Seems like a node dependency issue: https://github.com/INRIA/scikit-learn-mooc/actions/runs/3410391128/jobs/5673295661

I would be in favour of removing this workflow. I am not quite sure why it is useful and what it is supposed to test:

  • what is the Makefile actually testing, that remarker can produce a html, but it probably does not guarantee anything whether the slides looks good or not.
  • do we care about PDF slides? I don't think we use them for the MOOC but maybe I am wrong ...

We should also remove the instructions with remarker in the README or at least we should explain why this is needed ... I never used them personally.

@lesteve
Copy link
Collaborator Author

lesteve commented Nov 8, 2022

cc @brospars in case he remembers why the slides-ci workflow was useful

@brospars
Copy link
Collaborator

I think it's a relic from : lesteve/scikit-learn-tutorial#22 but it's not used anymore.

@lesteve
Copy link
Collaborator Author

lesteve commented Nov 10, 2022

OK thanks, in 59e27ab I removed the workflow and also slides/Makefile and related things, since I don't think this is used anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants