Hash collisions unhandled in Basic pool

[insaneinside]

The symbol pool implemented in basic.rs uses a value's hash as the key to pool's HashMap instance, which effectively bypasses any collision handling that would normally be provided by the map. This design was meant to avoid the overhead and additional complexity of using something like Rc where shared ownership isn't actually required — but clearly needs some rethinking.

[insaneinside]

@Robbepop, thanks for the heads-up here. I think the solution you used in your own string-interner crate might be a good fit here; you're welcome to make a pull request if you're interested (otherwise I'll look at this within a day or two).

[Robbepop]

@insaneinside I forked and tried to build your symtern in order to make the pull request but your crate does not compile at all on my computer. many errors and warnings around non-implemented traits, traits out of scope and non-matched trait bounds. I am using the nightly rust compiler.

[insaneinside]

My apologies! If you're still interested in taking a stab at this, you should be able to start at the tag "v0.1.0-pre.1" (which corresponds to the latest version on crates.io); I'll take care of any later merge conflicts that result.

[Robbepop]

Good to know!
I will look at it as soon as I find time. :)

[dralley]

I don't suppose either of you ever got around to this?

[Robbepop]

@dralley correct