Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate to english #7

Closed
HealerMikado opened this issue Jun 21, 2019 · 8 comments
Closed

Translate to english #7

HealerMikado opened this issue Jun 21, 2019 · 8 comments

Comments

@HealerMikado
Copy link
Collaborator

There is a lot of french in the application (documentation or fields/variables/methods/classes name) which need to be translate in English.

@Nolife999
Copy link
Contributor

Franck, could you please take care of the follwing module in the package ARC/arc-utils/src/main/java/fr/insee/arc/utils/ ?
batch
bdd
dao
files
format
Thank you

@Nolife999
Copy link
Contributor

Romain, could you please take care of the follwing module in the package ARC/arc-utils/src/main/java/fr/insee/arc/utils/ ?
ressourceUtils
sqlengine
structure
textUtils
utils
webutils
Thank you

@Nolife999
Copy link
Contributor

Nolife999 commented Jul 2, 2019

Nolife999, translate arc-core

@romaintailhurat
Copy link
Contributor

There are still some french text parts in the POMs ; because those are mainly training guidelines, they can be removed.

@romaintailhurat
Copy link
Contributor

In the Token class, we store StringToken constants that are used by the engine to build expressions.

The form of a token is like:

public static final IToken TOK_NOM_PHASE = new StringToken("tok_nom_phase");

It's easy to refactor the constant name (TOK_NOM_PHASE in this case), my IDE will work through all the renamings.

This is not the case for the string part ("tok_nom_phase"), and it is obviously not the case if this string exists somewhere else (not in the java code but in a DB trigger or a property).

Do you know if i can safely rename the string parts or if not, where are the dependencies ?

@romaintailhurat
Copy link
Contributor

Hi there.

I'll resume my work on translating the code, and i still need an answer on my previous comment, please. 🐼 👍

@romaintailhurat
Copy link
Contributor

Do you know if i can safely rename the string parts or if not, where are the dependencies ?

According to @Nolife999 it's okay, good to go. 👌

@romaintailhurat
Copy link
Contributor

romaintailhurat commented Aug 29, 2019

I'm done translating my part, maybe i can start working on translating part of the arc-core package ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants