Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMT01 UAT feedback #28

Closed
5 tasks done
barnett11 opened this issue Sep 10, 2021 · 2 comments · Fixed by #65
Closed
5 tasks done

DMT01 UAT feedback #28

barnett11 opened this issue Sep 10, 2021 · 2 comments · Fixed by #65
Assignees
@BFalquet

Comments

@barnett11
Copy link
Contributor

barnett11 commented Sep 10, 2021 •
edited by BFalquet
Loading

  • Header should include in notes that BWGHTSI needs to be merged into ADSL before running
  • Should the user be able to format the appearance of the variable label in Chevron (eg. Age to appear as "Age (yr)" and should we have the defaults built in?
  • Should formatting of values and order of values be done inside or outside of Chevron (eg. Gender to appear as Male / Female) and should we have defaults built in?
  • Template suggests a space between each variable presented, is this possible?
  • If a variable has 0 count, it is dropped. Should there be some warning or message to user that this is happening?
@barnett11
Copy link
Contributor Author

  1. Should header include a full description of the function inputs?

@BFalquet BFalquet self-assigned this Sep 29, 2021
@BFalquet
Copy link
Contributor

  • Function description was updated and the new utility function pivot_wider_labels makes joining data from ADSUB to ADSL easier.
  • Arguments have been updated to facilitate renaming of variable labels.
  • A new issue has been created concerning value reformatting.
  • spaces have been introduced between variables.
  • The general problem of the 0 count rows will be addressed in another issue.

@BFalquet BFalquet mentioned this issue Sep 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BFalquet BFalquet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

28 DMT01 UAT feedback insightsengineering/chevron
2 participants
@BFalquet @barnett11