Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move test dsl01 out of rlisting to scda.test #86

Closed
shajoezhu opened this issue Feb 16, 2023 · 3 comments · Fixed by #88
Closed

move test dsl01 out of rlisting to scda.test #86

shajoezhu opened this issue Feb 16, 2023 · 3 comments · Fixed by #88
Assignees
@Melkiades
Labels
low priority sme

Comments

@shajoezhu
Copy link
Collaborator

No description provided.

@shajoezhu shajoezhu added the sme label Feb 16, 2023
@Melkiades Melkiades self-assigned this Feb 16, 2023
@Melkiades Melkiades mentioned this issue Feb 16, 2023
Merged
shajoezhu pushed a commit that referenced this issue Feb 16, 2023
@Melkiades
dsl01 test will go into scda.test (#88)
ceea708 
Fixes #86 #89
@gmbecker gmbecker reopened this Feb 17, 2023
@gmbecker
Copy link
Contributor

@shajoezhu @Melkiades this should be reverted. The test did not depend on scda, but rather on formatters::ex_adsl, and there wasn't any reason to remove it; reducing tests should only happen when there is a good reason (e.g., the feature being tested has been removed, the test takes too long and can't beoptimized, etc).

@shajoezhu
Copy link
Collaborator Author

Happy to leave this issue open for now if more discussion is needed.

@shajoezhu
Copy link
Collaborator Author

hey @gmbecker , following our discussion this morning. We can close issue now right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Melkiades Melkiades

Labels
low priority sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dsl01 test will go into scda.test insightsengineering/rlistings
3 participants
@gmbecker @shajoezhu @Melkiades