Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsl01 test will go into scda.test #88

Merged
merged 5 commits into from Feb 16, 2023
Merged

Conversation

Melkiades
Copy link
Contributor

@Melkiades Melkiades commented Feb 16, 2023

Fixes #86 #89

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ------------------------------------
R/paginate_listing.R        51       1  98.04%   55
R/rlistings_methods.R       99      15  84.85%   23-24, 32, 47, 105, 111-114, 200-206
R/rlistings.R              130      13  90.00%   287-290, 294-297, 321, 325-328
TOTAL                      280      29  89.64%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 6945eba

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@Melkiades Melkiades linked an issue Feb 16, 2023 that may be closed by this pull request
@Melkiades Melkiades self-assigned this Feb 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

Unit Tests Summary

  1 files    2 suites   0s ⏱️
  9 tests   9 ✔️ 0 💤 0
45 runs  45 ✔️ 0 💤 0

Results for commit cccc492.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
listing_dsl01 💀 $0.11$ $-0.11$ $-9$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
listing_dsl01 💀 $0.11$ $-0.11$ DSL01_listing_is_produced_correctly

Results for commit 6945eba

♻️ This comment has been updated with latest results.

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@shajoezhu shajoezhu enabled auto-merge (squash) February 16, 2023 14:58
@shajoezhu shajoezhu merged commit ceea708 into main Feb 16, 2023
@shajoezhu shajoezhu deleted the 86_move_dsl01_to_test@main branch February 16, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sme test 🚨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding scda.test to rlinsting downstream move test dsl01 out of rlisting to scda.test
3 participants